[Freedreno] [PATCH 3/7] Revert "drm/atomic: Add solid fill data to plane state dump"
Dmitry Baryshkov
dmitry.baryshkov at linaro.org
Mon Dec 4 13:13:50 UTC 2023
This reverts commit e86413f5442ee094e66b3e75f2d3419ed0df9520.
Altough the Solid Fill planes patchset got all reviews and
acknowledgements, it doesn't fulfill requirements for the new uABI. It
has neither corresponding open-source userspace implementation nor the
IGT tests coverage. Reverting this patchset until userspace obligations
are fulfilled.
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov at linaro.org>
---
drivers/gpu/drm/drm_atomic.c | 4 ----
drivers/gpu/drm/drm_plane.c | 8 --------
include/drm/drm_plane.h | 3 ---
3 files changed, 15 deletions(-)
diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c
index 1339785fbe80..02aa7df832cc 100644
--- a/drivers/gpu/drm/drm_atomic.c
+++ b/drivers/gpu/drm/drm_atomic.c
@@ -726,10 +726,6 @@ static void drm_atomic_plane_print_state(struct drm_printer *p,
drm_printf(p, "\tfb=%u\n", state->fb ? state->fb->base.id : 0);
if (state->fb)
drm_framebuffer_print_info(p, 2, state->fb);
- drm_printf(p, "\tsolid_fill=%u\n",
- state->solid_fill_blob ? state->solid_fill_blob->base.id : 0);
- if (state->solid_fill_blob)
- drm_plane_solid_fill_print_info(p, 2, state);
drm_printf(p, "\tcrtc-pos=" DRM_RECT_FMT "\n", DRM_RECT_ARG(&dest));
drm_printf(p, "\tsrc-pos=" DRM_RECT_FP_FMT "\n", DRM_RECT_FP_ARG(&src));
drm_printf(p, "\trotation=%x\n", state->rotation);
diff --git a/drivers/gpu/drm/drm_plane.c b/drivers/gpu/drm/drm_plane.c
index c65c72701dd2..c8dbe5ae60cc 100644
--- a/drivers/gpu/drm/drm_plane.c
+++ b/drivers/gpu/drm/drm_plane.c
@@ -1641,14 +1641,6 @@ __drm_plane_get_damage_clips(const struct drm_plane_state *state)
state->fb_damage_clips->data : NULL);
}
-void drm_plane_solid_fill_print_info(struct drm_printer *p, unsigned int indent,
- const struct drm_plane_state *state)
-{
- drm_printf_indent(p, indent, "r=0x%08x\n", state->solid_fill.r);
- drm_printf_indent(p, indent, "g=0x%08x\n", state->solid_fill.g);
- drm_printf_indent(p, indent, "b=0x%08x\n", state->solid_fill.b);
-}
-
/**
* drm_plane_get_damage_clips - Returns damage clips.
* @state: Plane state.
diff --git a/include/drm/drm_plane.h b/include/drm/drm_plane.h
index d14e2f1db234..4b7af4381bbe 100644
--- a/include/drm/drm_plane.h
+++ b/include/drm/drm_plane.h
@@ -1025,9 +1025,6 @@ drm_plane_get_damage_clips_count(const struct drm_plane_state *state);
struct drm_mode_rect *
drm_plane_get_damage_clips(const struct drm_plane_state *state);
-void drm_plane_solid_fill_print_info(struct drm_printer *p, unsigned int indent,
- const struct drm_plane_state *state);
-
int drm_plane_create_scaling_filter_property(struct drm_plane *plane,
unsigned int supported_filters);
--
2.42.0
More information about the Freedreno
mailing list