[Freedreno] [PATCH v3 17/27] drm/msm/dpu: rewrite plane's QoS-related functions to take dpu_sw_pipe and dpu_format

[Abhinav Kumar]

On 2/3/2023 3:20 PM, Dmitry Baryshkov wrote:
> On 04/02/2023 01:07, Abhinav Kumar wrote:
>>
>>
>> On 2/3/2023 10:21 AM, Dmitry Baryshkov wrote:
>>> Rewrite dpu_plane's QoS related functions to take struct dpu_sw_pipe and
>>> struct dpu_format as arguments rather than fetching them from the
>>> pstate or drm_framebuffer.
>>>
>>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov at linaro.org>
>>
>> Nothing wrong with the change as such but why is this needed?
>> I looked through tne next patches in the series briefly and unless I 
>> am missing something, I am not able to see how this rewrite is helping 
>> or needed for the remaining patches.
> 
> Having a separate pipe argument eases adding support for r_pipe. After 
> all these changes only upper level functions access pstate->pipe. Then 
> it becomes natural to do:
> 
> dpu_plane_do_something(plane->pipe);
> if (plane->r_pipe)
>      dpu_plane_do_something(plane->r_pipe);

Understood,

Reviewed-by: Abhinav Kumar <quic_abhinavk at quicinc.com>