[Freedreno] [PATCH v2 05/50] drm/msm/dpu: fix sm6115 and qcm2290 mixer width limits

[Abhinav Kumar]

On 2/11/2023 3:12 PM, Dmitry Baryshkov wrote:
> According to vendor DTS files both sm6116 and qcm2290 should have
> max_mixer_width set to 2048 (DEFAULT_DPU_LINE_WIDTH). Correct it.

sm6116 ---> sm6115

> 
> Fixes: 3581b7062cec ("drm/msm/disp/dpu1: add support for display on SM6115")
> Fixes: 5334087ee743 ("drm/msm: add support for QCM2290 MDSS")
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov at linaro.org>

With that nit fixed,

Reviewed-by: Abhinav Kumar <quic_abhinavk at quicinc.com>

One more comment below but for a separate change.

> ---
>   drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
> index 47de609e2279..192fff9238f9 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
> @@ -318,7 +318,7 @@ static const struct dpu_caps msm8998_dpu_caps = {
>   };
>   
>   static const struct dpu_caps qcm2290_dpu_caps = {
> -	.max_mixer_width = DEFAULT_DPU_OUTPUT_LINE_WIDTH,
> +	.max_mixer_width = DEFAULT_DPU_LINE_WIDTH,
>   	.max_mixer_blendstages = 0x4,
>   	.smart_dma_rev = DPU_SSPP_SMART_DMA_V2,
>   	.has_dim_layer = true,
> @@ -356,7 +356,7 @@ static const struct dpu_caps sc7180_dpu_caps = {
>   };
>   
>   static const struct dpu_caps sm6115_dpu_caps = {
> -	.max_mixer_width = DEFAULT_DPU_OUTPUT_LINE_WIDTH,
> +	.max_mixer_width = DEFAULT_DPU_LINE_WIDTH,
>   	.max_mixer_blendstages = 0x4,
>   	.qseed_type = DPU_SSPP_SCALER_QSEED3LITE,
>   	.smart_dma_rev = DPU_SSPP_SMART_DMA_V2, /* TODO: v2.5 */
> @@ -1520,7 +1520,7 @@ static const struct dpu_lm_cfg sc7280_lm[] = {
>   /* QCM2290 */
>   
>   static const struct dpu_lm_sub_blks qcm2290_lm_sblk = {
> -	.maxwidth = DEFAULT_DPU_OUTPUT_LINE_WIDTH,
> +	.maxwidth = DEFAULT_DPU_LINE_WIDTH,

This looks like another cleanup idea. Since the lm_sub_blk already has a 
maxwidth doe we need to have max_mixer_width too? It seems like we can 
drop one of them.

>   	.maxblendstages = 4, /* excluding base layer */
>   	.blendstage_base = { /* offsets relative to mixer base */
>   		0x20, 0x38, 0x50, 0x68