[Freedreno] [PATCH 1/2] drm/msm/dpu: point sc8280xp_dpu_cfg to sc8280xp_regdma

[Abhinav Kumar]

On 1/17/2023 6:09 PM, Dmitry Baryshkov wrote:
> On 18/01/2023 04:08, Abhinav Kumar wrote:
>>
>>
>> On 1/17/2023 6:04 PM, Dmitry Baryshkov wrote:
>>> SC8280XP configuration missed the reg_dma configuration. We do not use
>>> regdma for now, but let's put the correct pointer anyway.
>>>
>>> Fixes: 4a352c2fc15a ("drm/msm/dpu: Introduce SC8280XP")
>>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov at linaro.org>
>>> ---
>>>   drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 2 ++
>>>   1 file changed, 2 insertions(+)
>>>
>>> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c 
>>> b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
>>> index 4375e72a9aab..3d0fbc1746e2 100644
>>> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
>>> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
>>> @@ -2680,6 +2680,8 @@ static const struct dpu_mdss_cfg 
>>> sc8280xp_dpu_cfg = {
>>>       .intf = sc8280xp_intf,
>>>       .vbif_count = ARRAY_SIZE(sdm845_vbif),
>>>       .vbif = sdm845_vbif,
>>> +    .reg_dma_count = 1,
>>
>> Lets stick to the convention of the rest of the entries and use 
>> ARRAY_SIZE.
> 
> regdma is not an array, so all platforms use 1 here. We should probably 
> change this, as some of newer platforms seem to have two regdma blocks, 
> but I haven't taken a look into that.

Ah .... ack, then this is fine. We should probably change that though,

Reviewed-by: Abhinav Kumar <quic_abhinavk at quicinc.com>

> 
>>
>>> +    .dma_cfg = &sc8280xp_regdma,
>>>       .perf = &sc8280xp_perf_data,
>>>       .mdss_irqs = IRQ_SC8280XP_MASK,
>>>   };
>