[Freedreno] [PATCH v2 1/3] drm/msm/mdss: convert UBWC setup to use match data

[Dmitry Baryshkov]

On 24/01/2023 03:48, Abhinav Kumar wrote:
> 
> 
> On 1/19/2023 9:26 PM, Dmitry Baryshkov wrote:
>> On Fri, 20 Jan 2023 at 00:54, Abhinav Kumar 
>> <quic_abhinavk at quicinc.com> wrote:
>>>
>>>
>>>
>>> On 1/17/2023 5:04 PM, Dmitry Baryshkov wrote:
>>>> To simplify adding new platforms and to make settings more obvious,
>>>> rewrite the UBWC setup to use the data structure to pass platform 
>>>> config
>>>> rather than just calling the functions direcly.
>>>>
>>>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov at linaro.org>
>>>
>>> I was reviewing this series and
>>> https://patchwork.freedesktop.org/series/111732/ together.
>>>
>>> More I think about it, it seems like we are duplicating the same values
>>> here and in the catalog.
>>>
>>> Yes, these two are different drivers.
>>>
>>> But now that you are adding the UBWC entries here using the compatible
>>> string so you are creating something like a "catalog" here.
>>>
>>> In that case, why dont we remove the entries from dpu catalog and in the
>>> DPU driver get the parent's match data as we know that the msm_mdss is
>>> the parent of DPU driver
>>
>> I should give it a thought, especially since we are trying to clean up
>> the DPU catalog.
> 
> I just went through the cover letter of 
> https://patchwork.freedesktop.org/patch/519752/ and it mentions
> 
> "My itent is to land both series and then to make
> DPU request this data from the MDSS driver"
> 
> This means that the parent data suggestion will be implemented?

Yes, at some point. You probably saw the dpu_ubwc_cfg structure. As I 
wrote, I'd like to get it from MDSS. Just looking for a best way to do this.


-- 
With best wishes
Dmitry