[Freedreno] [PATCH 1/2] drm/msm/dpu: drop SSPP register dumpers

Marijn Suijten marijn.suijten at somainline.org
Wed Jun 14 10:41:12 UTC 2023


On 2023-06-14 12:39:13, Marijn Suijten wrote:
<snip>
> > > > -	/* add register dump support */
> > > > -	dpu_debugfs_create_regset32("src_blk", 0400,
> > > > -			debugfs_root,
> > > > -			sblk->src_blk.base + cfg->base,
> > > > -			sblk->src_blk.len,
> > 
> > Note that this fails to apply on top of
> > https://lore.kernel.org/linux-arm-msm/20230429012353.2569481-2-dmitry.baryshkov@linaro.org/
> 
> Also noticing just now that this whole patch makes sblk unused:

... thanks to rebasing on top of [1], which is now applied.

[1]: https://lore.kernel.org/all/20230518222238.3815293-6-dmitry.baryshkov@linaro.org/

- Marijn

> 
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c: In function '_dpu_hw_sspp_init_debugfs':
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c:620:41: warning: unused variable 'sblk' [-Wunused-variable]
>   620 |         const struct dpu_sspp_sub_blks *sblk = cfg->sblk;
>       |                                         ^~~~
> 
> - Marijn


More information about the Freedreno mailing list