[Freedreno] [PATCH v2 03/22] drm/msm/dpu: remove unused INTF_NONE interfaces

Marijn Suijten marijn.suijten at somainline.org
Fri Jun 16 12:28:27 UTC 2023


On 2023-06-16 12:49:29, Dmitry Baryshkov wrote:
> On 16/06/2023 01:26, Marijn Suijten wrote:
> > On 2023-06-13 03:09:42, Dmitry Baryshkov wrote:
> >> sm6115 and qcm2290 do not have INTF_0. Drop corresponding interface
> >> definitions.
> > 
> > As Abhinav said, add sm6375.
> > 
> > If it wasn't for sc8280xp using INTF_NONE for fake MST, we could have
> > dropped INTF_NONE and the special-cases in dpu_hw_interrupts.c and
> > dpu_hw_intf.c entirely!  Is that your plan?
> 
> I have not thought about it yet. Generally I think INTF_NONE might still 
> be useful to document interfaces that we do not want to support for some 
> reason (e.g. MST or 8974/8084 eDP interfaces).

Sounds good, then we only use it for existing but specialcase interfaces
rather than for bogus/empty entries in the catalog!

- Marijn

> > 
> >>
> >> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov at linaro.org>
> > 
> > Reviewed-by: Marijn Suijten <marijn.suijten at somainline.org>
> > 
> 
> -- 
> With best wishes
> Dmitry
> 


More information about the Freedreno mailing list