[Freedreno] [PATCH v5 16/32] drm/msm/dpu: move the rest of plane checks to dpu_plane_atomic_check()

[Abhinav Kumar]

On 3/13/2023 9:14 PM, Dmitry Baryshkov wrote:
> On 14/03/2023 06:02, Abhinav Kumar wrote:
>>
>>
>> On 3/9/2023 4:56 PM, Dmitry Baryshkov wrote:
>>> Move plane state updates from dpu_crtc_atomic_check() to the function
>>> where they belong: to dpu_plane_atomic_check().
>>>
>>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov at linaro.org>
>>
>> Can you please elaborate a bit on this comment?
>>
>> https://patchwork.freedesktop.org/patch/521356/?series=99909&rev=4#comment_949772 
>>
>>
>> Is something still missing? I dont see the multirects being cleared in 
>> dpu_plane_atomic_disable() before or even now.
> 
> It is done in the last patch, where it belongs. There is no need to 
> clear multirect setup until we support RECT_1.
> 

Yup, checked the relevant patch (it wasnt the last).

Reviewed-by: Abhinav Kumar <quic_abhinavk at quicinc.com>