[Freedreno] [PATCH] Revert "drm/msm/dp: Remove INIT_SETUP delay"

[Leonard Lausen]

>>>>>> [  275.025497] [drm:dpu_encoder_phys_vid_wait_for_commit_done:488]
>>>>>> [dpu error]vblank timeout
>>>>>> [  275.025514] [drm:dpu_kms_wait_for_commit_done:510] [dpu error]wait
>>>>>> for commit done returned -110
>>>>>> [  275.064141] [drm:dpu_encoder_frame_done_timeout:2382] [dpu
>>>>>> error]enc33 frame done timeout
>>>>
>>>> This is a different crash but the root-cause of both the issues is the
>>>> bridge hpd_enable/disable series.
>>>>
>>>> https://patchwork.freedesktop.org/patch/514414/
>>
>> Yes, the new patch to fix this issue is here
>>
>> https://patchwork.freedesktop.org/patch/538601/?series=118148&rev=3
>>
>> Apologies if you were not CCed on this, if a next version is CCed, 
>> will ask kuogee to cc you.
>>
>> Meanwhile, will be great if you can verify if it works for you and 
>> provide Tested-by tags.
>
> Hi Leonard,
>
> I had  cc you with v5 patches.
>
> Would you please verify it.

Hi Kuogee,

thank you. Verified the v6 patch fixes the regression when ported to
6.3.3. One non-fatal issue remains: Suspending and resuming the system
while USB-C DP monitor is connected triggers an error, though the system
recovers within a second without the need to unplug the cable.

[drm:drm_mode_config_helper_resume] *ERROR* Failed to resume (-107)


dmesg snippet related to the suspend below

[  194.066321] PM: suspend entry (deep)
[  194.178793] Filesystems sync: 0.108 seconds
[  194.184142] LoadPin: firmware pinning-ignored obj="/usr/lib/firmware/qcom/sc7180-trogdor/modem-nolte/qdsp6sw.mbn" pid=3380 cmdline=""
[  194.196934] LoadPin: firmware pinning-ignored obj="/usr/lib/firmware/qcom/sc7180-trogdor/modem-nolte/mba.mbn" pid=3387 cmdline=""
[  194.197320] LoadPin: firmware pinning-ignored obj="/usr/lib/firmware/regulatory.db-debian" pid=3390 cmdline=""
[  194.204128] LoadPin: firmware pinning-ignored obj="/usr/lib/firmware/qcom/venus-5.4/venus.mbn" pid=3380 cmdline=""
[  194.204808] LoadPin: firmware pinning-ignored obj="/usr/lib/firmware/qca/crbtfw32.tlv" pid=3380 cmdline=""
[  194.205058] LoadPin: firmware pinning-ignored obj="/usr/lib/firmware/qca/crnv32.bin" pid=3380 cmdline=""
[  194.253591] Freezing user space processes
[  194.263621] Freezing user space processes completed (elapsed 0.005 seconds)
[  194.270816] OOM killer disabled.
[  194.274165] Freezing remaining freezable tasks
[  194.281253] Freezing remaining freezable tasks completed (elapsed 0.002 seconds)
[  194.288866] printk: Suspending console(s) (use no_console_suspend to debug)
[  194.494479] Disabling non-boot CPUs ...
[  194.497569] psci: CPU1 killed (polled 1 ms)
[  194.501844] psci: CPU2 killed (polled 1 ms)
[  194.506311] psci: CPU3 killed (polled 1 ms)
[  194.510237] psci: CPU4 killed (polled 1 ms)
[  194.512854] psci: CPU5 killed (polled 1 ms)
[  194.516076] psci: CPU6 killed (polled 1 ms)
[  194.518397] psci: CPU7 killed (polled 0 ms)
[  194.520706] Enabling non-boot CPUs ...
[  194.521595] Detected VIPT I-cache on CPU1
[  194.521664] cacheinfo: Unable to detect cache hierarchy for CPU 1
[  194.521678] GICv3: CPU1: found redistributor 100 region 0:0x0000000017a80000
[  194.521743] CPU1: Booted secondary processor 0x0000000100 [0x51df805e]
[  194.522829] CPU1 is up
[  194.523646] Detected VIPT I-cache on CPU2
[  194.523701] cacheinfo: Unable to detect cache hierarchy for CPU 2
[  194.523716] GICv3: CPU2: found redistributor 200 region 0:0x0000000017aa0000
[  194.523775] CPU2: Booted secondary processor 0x0000000200 [0x51df805e]
[  194.524809] CPU2 is up
[  194.525537] Detected VIPT I-cache on CPU3
[  194.525592] cacheinfo: Unable to detect cache hierarchy for CPU 3
[  194.525611] GICv3: CPU3: found redistributor 300 region 0:0x0000000017ac0000
[  194.525668] CPU3: Booted secondary processor 0x0000000300 [0x51df805e]
[  194.526674] CPU3 is up
[  194.527486] Detected VIPT I-cache on CPU4
[  194.527535] cacheinfo: Unable to detect cache hierarchy for CPU 4
[  194.527556] GICv3: CPU4: found redistributor 400 region 0:0x0000000017ae0000
[  194.527612] CPU4: Booted secondary processor 0x0000000400 [0x51df805e]
[  194.528836] CPU4 is up
[  194.529553] Detected VIPT I-cache on CPU5
[  194.529601] cacheinfo: Unable to detect cache hierarchy for CPU 5
[  194.529623] GICv3: CPU5: found redistributor 500 region 0:0x0000000017b00000
[  194.529675] CPU5: Booted secondary processor 0x0000000500 [0x51df805e]
[  194.530986] CPU5 is up
[  194.532280] Detected PIPT I-cache on CPU6
[  194.532307] cacheinfo: Unable to detect cache hierarchy for CPU 6
[  194.532322] GICv3: CPU6: found redistributor 600 region 0:0x0000000017b20000
[  194.532358] CPU6: Booted secondary processor 0x0000000600 [0x51ff804f]
[  194.534434] CPU6 is up
[  194.535408] Detected PIPT I-cache on CPU7
[  194.535445] cacheinfo: Unable to detect cache hierarchy for CPU 7
[  194.535463] GICv3: CPU7: found redistributor 700 region 0:0x0000000017b40000
[  194.535505] CPU7: Booted secondary processor 0x0000000700 [0x51ff804f]
[  194.536281] CPU7 is up
[  195.285023] onboard-usb-hub 1-1: reset high-speed USB device number 2 using xhci-hcd
[  195.541240] onboard-usb-hub 2-1: reset SuperSpeed USB device number 2 using xhci-hcd
[  195.796915] usb 1-1.4: reset high-speed USB device number 22 using xhci-hcd
[  195.972952] usb 2-1.4: reset SuperSpeed USB device number 10 using xhci-hcd
[  196.278492] usb 1-1.4.4: reset high-speed USB device number 24 using xhci-hcd
[  196.468996] usb 1-1.4.2: reset high-speed USB device number 26 using xhci-hcd
[  197.055717] usb 2-1.4.2: reset SuperSpeed USB device number 11 using xhci-hcd
[  197.845110] usb 2-1.4.4: reset SuperSpeed USB device number 12 using xhci-hcd
[  198.235191] [drm:drm_mode_config_helper_resume] *ERROR* Failed to resume (-107)
[  198.528638] OOM killer enabled.
[  198.531866] Restarting tasks ... 
[  198.531994] usb 1-1.4.4.1: USB disconnect, device number 27
[  198.532223] usb 1-1.4.3: USB disconnect, device number 23
[  198.532509] usb 1-1.4.2.1: USB disconnect, device number 29
[  198.534805] r8152-cfgselector 2-1.4.4.2: USB disconnect, device number 13
[  198.535444] done.
[  198.535536] usb 1-1.1: USB disconnect, device number 15
[  198.567811] random: crng reseeded on system resumption
[  198.583431] PM: suspend exit