[Freedreno] [PATCH v3 2/6] dt-bindings: display/msm: Add reg bus and rotator interconnects

[Konrad Dybcio]

On 11/6/23 16:45, Neil Armstrong wrote:
> Hi,
> 
> On 28/09/2023 13:35, Dmitry Baryshkov wrote:
>> From: Konrad Dybcio <konrad.dybcio at linaro.org>
>>
>> Apart from the already handled data bus (MAS_MDP_Pn<->DDR), there are
>> other connection paths:
>> - a path that connects rotator block to the DDR.
>> - a path that needs to be handled to ensure MDSS register access
>>    functions properly, namely the "reg bus", a.k.a the CPU-MDSS CFG
>>    interconnect.
>>
>> Describe these paths bindings to allow using them in device trees and in
>> the driver
>>
>> Signed-off-by: Konrad Dybcio <konrad.dybcio at linaro.org>
>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski at linaro.org>
>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov at linaro.org>
>> ---
>>   Documentation/devicetree/bindings/display/msm/mdss-common.yaml | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/display/msm/mdss-common.yaml b/Documentation/devicetree/bindings/display/msm/mdss-common.yaml
>> index f69196e4cc76..6b4ce08a60dc 100644
>> --- a/Documentation/devicetree/bindings/display/msm/mdss-common.yaml
>> +++ b/Documentation/devicetree/bindings/display/msm/mdss-common.yaml
>> @@ -66,12 +66,14 @@ properties:
>>       items:
>>         - description: Interconnect path from mdp0 (or a single mdp) port to the data bus
>>         - description: Interconnect path from mdp1 port to the data bus
>> +      - description: Interconnect path from CPU to the reg bus
>>     interconnect-names:
>>       minItems: 1
>>       items:
>>         - const: mdp0-mem
>>         - const: mdp1-mem
>> +      - const: cpu-cfg
>>     resets:
>>       items:
> 
> This is not enough, on sm8450 this still appears with patch applied:
> arch/arm64/boot/dts/qcom/sm8450-hdk.dtb: display-subsystem at ae00000: interconnects: [[182, 14, 0, 30, 3, 0], [182, 14, 0, 30, 3, 0], [53, 2, 3, 183, 14, 3]] is too long
>          from schema $id: http://devicetree.org/schemas/display/msm/qcom,sm8450-mdss.yaml#
> arch/arm64/boot/dts/qcom/sm8450-hdk.dtb: display-subsystem at ae00000: interconnect-names: ['mdp0-mem', 'mdp1-mem', 'cpu-cfg'] is too long
>          from schema $id: http://devicetree.org/schemas/display/msm/qcom,sm8450-mdss.yaml#
I assume this is with the path actually added in the dt, and
not just with this patch applied?

I guess increasing the numbers from the getgo would probably
be good idea too :)

Konrad