[Freedreno] [PATCH] drm/msm/dp: cleanup debugfs handling

Dmitry Baryshkov dmitry.baryshkov at linaro.org
Thu Oct 19 13:05:02 UTC 2023


On Thu, 19 Oct 2023 at 15:33, Abhinav Kumar <quic_abhinavk at quicinc.com> wrote:
>
>
>
> On 10/19/2023 3:44 AM, Dmitry Baryshkov wrote:
> > Currently there are two subdirs for DP debugfs files, e.g. DP-1, created
> > by the drm core for the connector, and the msm_dp-DP-1, created by the
> > DP driver itself. Merge those two, so that there are no extraneous
> > connector-related subdirs.
> >
> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov at linaro.org>
> > ---
>
>
> One concern with this is, we are migrating from one debugfs per
> dp_display to one debugfs per bridge.
>
> Today we create one bridge per dp_display so its fine.
>
> With MST, I am unsure if there will be changes needed.

For MST the add_connector callback creates a new connector with its
own implementation of  drm_connector_funcs. So if necessary we can
create debugfs files for this new connector.

> But, we will figure that out once we add that support,
>
> Hence,
>
> Reviewed-by: Abhinav Kumar <quic_abhinavk at quicinc.com>

-- 
With best wishes
Dmitry


More information about the Freedreno mailing list