[Freedreno] [PATCH v2 1/2] drm/msm/dp: don't touch DP subconnector property in eDP case
Abhinav Kumar
quic_abhinavk at quicinc.com
Fri Oct 27 21:02:03 UTC 2023
On 10/25/2023 2:23 AM, Dmitry Baryshkov wrote:
> From: Abel Vesa <abel.vesa at linaro.org>
>
> In case of the eDP connection there is no subconnetor and as such no
> subconnector property. Put drm_dp_set_subconnector_property() calls
> under the !is_edp condition.
>
> Fixes: bfcc3d8f94f4 ("drm/msm/dp: support setting the DP subconnector type")
> Signed-off-by: Abel Vesa <abel.vesa at linaro.org>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov at linaro.org>
> ---
> drivers/gpu/drm/msm/dp/dp_display.c | 15 ++++++++++-----
> 1 file changed, 10 insertions(+), 5 deletions(-)
>
We still need to unify the calls to drm_dp_set_subconnector_property()
for the hpd connect/disconnect places preferably in
dp_display_send_hpd_notification().
That way, we would have had to make this change only in one location.
If you want to pursue that as a separate patch, I am fine as well.
Hence,
Reviewed-by: Abhinav Kumar <quic_abhinavk at quicinc.com>
More information about the Freedreno
mailing list