[PATCH] drm/msm: convert all pixel format logging to use %p4cc
Dmitry Baryshkov
dmitry.baryshkov at linaro.org
Fri Apr 5 16:44:09 UTC 2024
On Fri, Apr 05, 2024 at 12:29:07PM +0300, Jani Nikula wrote:
> Logging u32 pixel formats using %4.4s format string with a pointer to
> the u32 is somewhat questionable, as well as dependent on byte
> order. There's a kernel extension format specifier %p4cc to format 4cc
> codes. Use it across the board in msm for pixel format logging.
>
> This should also fix the reported build warning:
>
> include/drm/drm_print.h:536:35: warning: '%4.4s' directive argument is
> null [-Wformat-overflow=]
>
> Reported-by: Aishwarya TCV <aishwarya.tcv at arm.com>
> Closes: https://lore.kernel.org/r/2ac758ce-a196-4e89-a397-488ba31014c4@arm.com
> Signed-off-by: Jani Nikula <jani.nikula at intel.com>
>
> ---
>
> Tip: 'git show --color-words -w' might be the easiest way to review.
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 8 +++----
> .../drm/msm/disp/dpu1/dpu_encoder_phys_wb.c | 2 +-
> drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c | 4 ++--
> drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 24 +++++++++----------
> drivers/gpu/drm/msm/msm_fb.c | 10 ++++----
> 5 files changed, 24 insertions(+), 24 deletions(-)
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov at linaro.org>
--
With best wishes
Dmitry
More information about the Freedreno
mailing list