[PATCH v4 15/19] drm/msm/dp: enable SDP and SDE periph flush update

Dmitry Baryshkov dmitry.baryshkov at linaro.org
Sat Feb 17 08:59:38 UTC 2024


On Sat, 17 Feb 2024 at 01:03, Paloma Arellano <quic_parellan at quicinc.com> wrote:
>
> DP controller can be setup to operate in either SDP update flush mode or
> peripheral flush mode based on the DP controller hardware version.
>
> Starting in DP v1.2, the hardware documents require the use of
> peripheral flush mode for SDP packets such as PPS OR VSC SDP packets.
>
> In-line with this guidance, lets program the DP controller to use
> peripheral flush mode starting DP v1.2
>
> Changes in v4:
>         - Clear up that DP_MAINLINK_CTRL_FLUSH_MODE register requires
>           the use of bits [24:23]
>         - Modify macros DP_MAINLINK_FLUSH_MODE_UPDATE_SDP and
>           DP_MAINLINK_FLUSH_MODE_SDP_PERIPH_UPDATE to explicitly set
>           their values in the bits of DP_MAINLINK_CTRL_FLUSH_MODE_MASK
>
> Changes in v3:
>         - Clear up that the DP_MAINLINK_FLUSH_MODE_SDE_PERIPH_UPDATE
>           macro is setting bits [24:23] to a value of 3
>
> Changes in v2:
>         - Use the original dp_catalog_hw_revision() function to
>           correctly check the DP HW version
>
> Signed-off-by: Paloma Arellano <quic_parellan at quicinc.com>
> ---
>  drivers/gpu/drm/msm/dp/dp_catalog.c | 17 +++++++++++++++++
>  drivers/gpu/drm/msm/dp/dp_catalog.h |  1 +
>  drivers/gpu/drm/msm/dp/dp_ctrl.c    |  1 +
>  drivers/gpu/drm/msm/dp/dp_reg.h     |  6 ++++++
>  4 files changed, 25 insertions(+)

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov at linaro.org>

-- 
With best wishes
Dmitry


More information about the Freedreno mailing list