[REGRESSION] sc7180-trogdor-lazor image corruption regression for USB-C DP Alt Mode ([PATCH 0/2] Add param for the highest bank bit)

Leonard Lausen leonard at lausen.nl
Sun Feb 18 01:10:33 UTC 2024


Hi Connor,

unfortunately, your series https://patchwork.freedesktop.org/series/127529/ has introduced a regression for external displays connected through USB-C DP Alt Mode, at least on sc7180-trogdor-lazor devices. Do you think it's possible to  fix this before the 6.8 release or would it be better to revert the series? I'm happy to help testing any fixes. The issue is also tracked at https://gitlab.freedesktop.org/drm/msm/-/issues/49.

Thank you
Leonard

#regzbot introduced: 8814455a0e54ca353b4b0ad5105569d3fdb945cc

On 12/7/23 16:30, Connor Abbott wrote:
> The highest bank bit is a parameter that influences the Adreno tiling
> scheme. It is programmed by the kernel, and is supposed to be based on
> the DRAM configuration. In order for Mesa to tile/until images itself,
> it needs to know this parameter, and because it's programmed by the
> kernel, the kernel should be the source of truth.
> 
> Mesa series: https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26578
> 
> Connor Abbott (2):
>   drm/msm: Refactor UBWC config setting
>   drm/msm: Add param for the highest bank bit
> 
>  drivers/gpu/drm/msm/adreno/a5xx_gpu.c   |  21 ++---
>  drivers/gpu/drm/msm/adreno/a6xx_gpu.c   | 101 +++++++++++++-----------
>  drivers/gpu/drm/msm/adreno/adreno_gpu.c |   3 +
>  drivers/gpu/drm/msm/adreno/adreno_gpu.h |   9 +++
>  include/uapi/drm/msm_drm.h              |   1 +
>  5 files changed, 82 insertions(+), 53 deletions(-)
> 


More information about the Freedreno mailing list