[PATCH] drm/ci: Add msm tests

[Helen Koike]

On 15/01/2024 07:22, Vignesh Raman wrote:
> Hi Rob,
> 
> On 12/01/24 22:44, Rob Clark wrote:
>> On Fri, Jan 12, 2024 at 7:57 AM Rob Clark <robdclark at gmail.com> wrote:
>>>
>>> On Fri, Jan 12, 2024 at 3:42 AM Vignesh Raman
>>> <vignesh.raman at collabora.com> wrote:
>>>>
>>>> Hi Rob,
>>>>
>>>>
>>>> On 09/01/24 01:20, Rob Clark wrote:
>>>>> From: Rob Clark <robdclark at chromium.org>
>>>>>
>>>>> The msm tests should skip on non-msm hw, so I think it should be 
>>>>> safe to
>>>>> enable everywhere.
>>>>>
>>>>> Signed-off-by: Rob Clark <robdclark at chromium.org>

Acked-by: Helen Koike <helen.koike at collabora.com>

>>>>> ---
>>>>>    drivers/gpu/drm/ci/testlist.txt | 49 
>>>>> +++++++++++++++++++++++++++++++++
>>>>>    1 file changed, 49 insertions(+)
>>>>>
>>>>> diff --git a/drivers/gpu/drm/ci/testlist.txt 
>>>>> b/drivers/gpu/drm/ci/testlist.txt
>>>>> index f82cd90372f4..eaeb751bb0ad 100644
>>>>> --- a/drivers/gpu/drm/ci/testlist.txt
>>>>> +++ b/drivers/gpu/drm/ci/testlist.txt
>>>>> @@ -2910,3 +2910,52 @@ kms_writeback at writeback-invalid-parameters
>>>>>    kms_writeback at writeback-fb-id
>>>>>    kms_writeback at writeback-check-output
>>>>>    prime_mmap_kms at buffer-sharing
>>>>> +msm_shrink at copy-gpu-sanitycheck-8
>>>>> +msm_shrink at copy-gpu-sanitycheck-32
>>>>> +msm_shrink at copy-gpu-8
>>>>> +msm_shrink at copy-gpu-32
>>>>> +msm_shrink at copy-gpu-madvise-8
>>>>> +msm_shrink at copy-gpu-madvise-32
>>>>> +msm_shrink at copy-gpu-oom-8
>>>>> +msm_shrink at copy-gpu-oom-32
>>>>> +msm_shrink at copy-mmap-sanitycheck-8
>>>>> +msm_shrink at copy-mmap-sanitycheck-32
>>>>> +msm_shrink at copy-mmap-8
>>>>> +msm_shrink at copy-mmap-32
>>>>> +msm_shrink at copy-mmap-madvise-8
>>>>> +msm_shrink at copy-mmap-madvise-32
>>>>> +msm_shrink at copy-mmap-oom-8
>>>>> +msm_shrink at copy-mmap-oom-32
>>>>> +msm_shrink at copy-mmap-dmabuf-sanitycheck-8
>>>>> +msm_shrink at copy-mmap-dmabuf-sanitycheck-32
>>>>> +msm_shrink at copy-mmap-dmabuf-8
>>>>> +msm_shrink at copy-mmap-dmabuf-32
>>>>> +msm_shrink at copy-mmap-dmabuf-madvise-8
>>>>> +msm_shrink at copy-mmap-dmabuf-madvise-32
>>>>> +msm_shrink at copy-mmap-dmabuf-oom-8
>>>>> +msm_shrink at copy-mmap-dmabuf-oom-32
>>>>> +msm_mapping at ring
>>>>> +msm_mapping at sqefw
>>>>> +msm_mapping at shadow
>>>>> +msm_submitoverhead at submitbench-10-bos
>>>>> +msm_submitoverhead at submitbench-10-bos-no-implicit-sync
>>>>> +msm_submitoverhead at submitbench-100-bos
>>>>> +msm_submitoverhead at submitbench-100-bos-no-implicit-sync
>>>>> +msm_submitoverhead at submitbench-250-bos
>>>>> +msm_submitoverhead at submitbench-250-bos-no-implicit-sync
>>>>> +msm_submitoverhead at submitbench-500-bos
>>>>> +msm_submitoverhead at submitbench-500-bos-no-implicit-sync
>>>>> +msm_submitoverhead at submitbench-1000-bos
>>>>> +msm_submitoverhead at submitbench-1000-bos-no-implicit-sync
>>>>> +msm_recovery at hangcheck
>>>>> +msm_recovery at gpu-fault
>>>>> +msm_recovery at gpu-fault-parallel
>>>>> +msm_recovery at iova-fault
>>>>> +msm_submit at empty-submit
>>>>> +msm_submit at invalid-queue-submit
>>>>> +msm_submit at invalid-flags-submit
>>>>> +msm_submit at invalid-in-fence-submit
>>>>> +msm_submit at invalid-duplicate-bo-submit
>>>>> +msm_submit at invalid-cmd-idx-submit
>>>>> +msm_submit at invalid-cmd-type-submit
>>>>> +msm_submit at valid-submit
>>>>
>>>> I tested this patch with latest drm-misc/drm-misc-next and there was
>>>> some failures seen for the newly added msm tests. I have updated the
>>>> xfails with below commit,
>>>>
>>>> https://gitlab.freedesktop.org/vigneshraman/linux/-/commit/d012893597a661d6ebbb755bf2607dfb055524a1
>>>>
>>>> I will notify the maintainers about the flaky tests, update the url in
>>>> the flakes.txt, and submit a separate patch for this change.
>>
>> Oh, you should probably move msm_mapping@* to skips on sdm845.  I had
>> a closer look at those, and they are failing due to a bootloader/fw
>> issue.  We work around this in mesa CI with these two patches:
>>
>> https://gitlab.freedesktop.org/gfx-ci/linux/-/commit/4b49f902ec6f2bb382cbbf489870573f4b43371e
>> https://gitlab.freedesktop.org/gfx-ci/linux/-/commit/38cdf4c5559771e2474ae0fecef8469f65147bc1
>>
>> But given that sdm845 is similar to sc7180 as far as kernel gpu
>> driver, it is probably just better to skip these on sdm845 (with a
>> comment referring to the hack patches we use in mesa CI)
> 
> I have sent a patch with these changes,

Thanks!

Helen

> 
> https://lore.kernel.org/dri-devel/20240115101750.27077-1-vignesh.raman@collabora.com/T/#u
> 
> Thanks.
> 
> Regards,
> Vignesh
>