[PATCH v3 4/5] drm/msm/dpu: rework core_perf debugfs overrides

Abhinav Kumar quic_abhinavk at quicinc.com
Thu Mar 21 22:56:58 UTC 2024



On 3/13/2024 6:10 PM, Dmitry Baryshkov wrote:
> Currently debugfs provides separate 'modes' to override calculated
> MDP_CLK rate and interconnect bandwidth votes. Change that to allow
> overriding individual values (e.g. one can override just clock or just
> average bandwidth vote).
> 

I am not opposed to the idea of dropping modes and overriding individual 
values.

But, we cannot expect the user to know the max clock value and max BW 
value for each chipset by looking into the catalog or devicetree.

That was the whole point of the MODE_MINIMUM perf mode. User doesnt need 
to know "what values to program", just sets the "max" mode.

If you are also going to expose a "max_core_clk" and "max_bw" debugfs 
read nodes along with this along with the --help I spoke about in the 
prev patch, that will make this approach complete from my PoV.

> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov at linaro.org>
> ---
>   drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 87 +++------------------------
>   drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.h | 10 ---
>   2 files changed, 9 insertions(+), 88 deletions(-)
> 


More information about the Freedreno mailing list