[PATCH] drm/msm/mdp4: remove the use of dev_err_probe()
Dmitry Baryshkov
dmitry.baryshkov at oss.qualcomm.com
Thu Aug 21 10:38:05 UTC 2025
On Wed, Aug 20, 2025 at 09:12:56PM +0800, Liao Yuanhong wrote:
> Logging messages that show some type of "out of memory" error are generally
> unnecessary as there is a generic message and a stack dump done by the
> memory subsystem. These messages generally increase kernel size without
> much added value[1].
>
> The dev_err_probe() doesn't do anything when error is '-ENOMEM'. Therefore,
> remove the useless call to dev_err_probe(), and just return the value
> instead.
>
> [1]: https://lore.kernel.org/lkml/1402419340.30479.18.camel@joe-AO725/
>
> Signed-off-by: Liao Yuanhong <liaoyuanhong at vivo.com>
> ---
> drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov at oss.qualcomm.com>
--
With best wishes
Dmitry
More information about the Freedreno
mailing list