[PATCH 37/39] drm/atomic: Document __drm_crtcs_state state pointer
Maxime Ripard
mripard at kernel.org
Mon Aug 25 13:43:42 UTC 2025
While the old and new state pointers are somewhat self-explanatory, the
state pointer and its relation to the other two really isn't.
Now that we've cleaned up everything and it isn't used in any
modesetting path, we can document what it's still useful for: to free
the right state when we free the global state.
Signed-off-by: Maxime Ripard <mripard at kernel.org>
---
include/drm/drm_atomic.h | 16 +++++++++++++++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/include/drm/drm_atomic.h b/include/drm/drm_atomic.h
index cba63857e920515b48b75fc3c2d5239fc1ae59c1..e8edf33ab260c03c81e16917a6a5a7d9648d46c9 100644
--- a/include/drm/drm_atomic.h
+++ b/include/drm/drm_atomic.h
@@ -176,11 +176,25 @@ struct __drm_planes_state {
struct drm_plane_state *old_state, *new_state;
};
struct __drm_crtcs_state {
struct drm_crtc *ptr;
- struct drm_crtc_state *state, *old_state, *new_state;
+
+ /**
+ * @state:
+ *
+ * Used to track the @drm_crtc_state we will need to free
+ * when tearing down the associated &drm_atomic_state.
+ *
+ * Before a commit, and the call to
+ * drm_atomic_helper_swap_state() in particular, it points to
+ * the same state than @new_state. After a commit, it points to
+ * the same state than @old_state.
+ */
+ struct drm_crtc_state *state;
+
+ struct drm_crtc_state *old_state, *new_state;
/**
* @commit:
*
* A reference to the CRTC commit object that is kept for use by
--
2.50.1
More information about the Freedreno
mailing list