[PATCH] drm/msm/dpu: Disable dither in phys encoder cleanup

[Abhinav Kumar]

On 2/12/2025 12:23 PM, Abhinav Kumar wrote:
> 
> 
> On 2/11/2025 7:59 PM, Jessica Zhang wrote:
>> Disable pingpong dither in dpu_encoder_helper_phys_cleanup().
>>
>> This avoids the issue where an encoder unknowingly uses dither after
>> reserving a pingpong block that was previously bound to an encoder that
>> had enabled dither.
>>
>> Reported-by: Dmitry Baryshkov <dmitry.baryshkov at linaro.org>
>> Closes: https://lore.kernel.org/all/ 
>> jr7zbj5w7iq4apg3gofuvcwf4r2swzqjk7sshwcdjll4mn6ctt at l2n3qfpujg3q/
>> Signed-off-by: Jessica Zhang <quic_jesszhan at quicinc.com>
>> ---
>> This was tested on SC7180 Trogdor by pulling in the concurrent writeback
>> series [1] and running the IGT kms_writeback at writeback_check_output
>> subtest.
>>
>> [1] https://patchwork.freedesktop.org/series/144083/
>> ---
>>   drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 3 +++
>>   1 file changed, 3 insertions(+)
>>
> 
> Was an extremely tricky issue to debug.
> 
> Glad this one is resolved,
> 
> Reviewed-by: Abhinav Kumar <quic_abhinavk at quicinc.com>

Also going to add,

Fixes: 3c128638a07d ("drm/msm/dpu: add support for dither block in display")