[PATCH 1/4] dt-bindings: display/msm: Redocument the dp-controller for QCS8300

[Yongxing Mou]

On 2025/2/12 19:28, Krzysztof Kozlowski wrote:
> On 12/02/2025 12:13, Yongxing Mou wrote:
>>
>>
>> On 2025/2/12 16:35, Krzysztof Kozlowski wrote:
>>> On 12/02/2025 08:12, Yongxing Mou wrote:
>>>> We need to enable mst for qcs8300, dp0 controller will support 2 streams
>>>> output. So not reuse sm8650 dp controller driver and will add a new driver
>>>> patch for qcs8300 mst feature. Modify the corresponding dt-bingding file
>>>> to compatible with the qcs8300-dp.
>>>>
>>>> Signed-off-by: Yongxing Mou <quic_yongmou at quicinc.com>
>>> NAK. You just said qcs8300 is compatible with sm8650. I did not ask
>>> about drivers, I asked about hardware.
>>>
>>> This is messy approach. Describe properly the hardware first, instead of
>>> sending two conflicting patchsets.
>>>
>>> Best regards,
>>> Krzysztof
>>
>> Hi, Krzysztof, thanks for reviewing, i want to explain why i submitted
>> this patch. Patch
>> https://lore.kernel.org/all/20250114-dts_qcs8300-v3-1-d114cc5e4af9@quicinc.com/
>> and
>> https://lore.kernel.org/all/20250120-mdssdt_qcs8300-v4-2-1687e7842125@quicinc.com/
>> is the qcs8300 display enablement changes. It base on current linux base
>> code and it only support SST mode, so in the SST mode, qcs8300 dp
>> controller driver is quite same with sm8650, struct msm_dp_desc only
>> have 3 members(io_start, id and wide_bus_supported) and they are same
>> both in qcs8300 and sm8650, so we reuse it. BTW, for dp phy hardware
>> version, qcs8300 and sm8650 is different.
> 
> No. In one patchset you claim hardware is like that, in other patchset
> you say hardware is different.
> 
> Sorry, hardware does not change based on your patchsets.
> 
> Sort out this before posting new versions.
> 
> Best regards,
> Krzysztof

Got it , thanks . The 4 clocks description will be updated in the new 
patch. Qcs8300 support 4 intfs in DP0, sm8650 supports 2 intfs in 
hardware.