[PATCH v2 08/16] drm/msm/dpu: Drop useless comments

Jessica Zhang quic_jesszhan at quicinc.com
Wed Feb 19 21:19:25 UTC 2025



On 2/17/2025 8:41 AM, Krzysztof Kozlowski wrote:
> Drop comments about SoC before each 'struct dpu_lm_sub_blks' for given
> SoC because it's duplicating the actual name of structure.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski at linaro.org>

Reviewed-by: Jessica Zhang <quic_jesszhan at quicinc.com>

> ---
>   drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 8 --------
>   1 file changed, 8 deletions(-)
> 
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
> index 7ea424d7c1b75e06312692225f4e888e81621283..4ff29be965c39b29cf7e3b9761634b7f39ca97b0 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
> @@ -362,8 +362,6 @@ static const struct dpu_sspp_sub_blks dpu_dma_sblk = _DMA_SBLK();
>    * MIXER sub blocks config
>    *************************************************************/
>   
> -/* MSM8998 */
> -
>   static const struct dpu_lm_sub_blks msm8998_lm_sblk = {
>   	.maxwidth = DEFAULT_DPU_OUTPUT_LINE_WIDTH,
>   	.maxblendstages = 7, /* excluding base layer */
> @@ -373,8 +371,6 @@ static const struct dpu_lm_sub_blks msm8998_lm_sblk = {
>   	},
>   };
>   
> -/* SDM845 */
> -
>   static const struct dpu_lm_sub_blks sdm845_lm_sblk = {
>   	.maxwidth = DEFAULT_DPU_OUTPUT_LINE_WIDTH,
>   	.maxblendstages = 11, /* excluding base layer */
> @@ -384,8 +380,6 @@ static const struct dpu_lm_sub_blks sdm845_lm_sblk = {
>   	},
>   };
>   
> -/* SC7180 */
> -
>   static const struct dpu_lm_sub_blks sc7180_lm_sblk = {
>   	.maxwidth = DEFAULT_DPU_OUTPUT_LINE_WIDTH,
>   	.maxblendstages = 7, /* excluding base layer */
> @@ -394,8 +388,6 @@ static const struct dpu_lm_sub_blks sc7180_lm_sblk = {
>   	},
>   };
>   
> -/* QCM2290 */
> -
>   static const struct dpu_lm_sub_blks qcm2290_lm_sblk = {
>   	.maxwidth = DEFAULT_DPU_LINE_WIDTH,
>   	.maxblendstages = 4, /* excluding base layer */
> 
> -- 
> 2.43.0
> 



More information about the Freedreno mailing list