[PATCH v2 25/25] drm/xlnx: Compute dumb-buffer sizes with drm_mode_size_dumb()
Tomi Valkeinen
tomi.valkeinen at ideasonboard.com
Mon Jan 20 08:51:23 UTC 2025
Hi,
On 20/01/2025 09:49, Thomas Zimmermann wrote:
> Hi
>
>
> Am 16.01.25 um 11:03 schrieb Tomi Valkeinen:
> [...]
>> Aligning video= and dumb buffers almost sounds like going backwards.
>> video= parameter is bad,
>
> Who told you that? Video= is still the way to specify an initial display
> mode to the kernel and it will remain so.
You did =). "It aligns dumb buffers and video=". I understand the need
for drm_driver_color_mode_format() for video=. But I think it's bad for
CREATE_DUMB, at least for the platforms which have never aimed for
"RGB-only".
So you're not in favor of a drm_mode_size_dumb() version that does not
use drm_driver_color_mode_format(), for these platforms? I'm still at
loss as to why we would want to change the behavior of CREATE_DUMB. I
see no upside, but I see the chance of regressions.
Tomi
More information about the Freedreno
mailing list