<p>OK，i will do that</p><br>

    <p>----</p><p></p><p><br></p><p></p><div id="re" style="margin-left:0.5em;padding-left:0.5em;border-left:1px solid green;"><br><br><br>
        <div style="background-color:#f5f7fa"><b>主　题：</b><span id="subject">Re: [PATCH] drm/msm/dpu: Fix variable dereferenced before check</span>
            <br><b>日　期：</b><span id="date">2022-06-23 01:28</span>
            <br><b>发件人：</b><span id="from">Abhinav Kumar</span>
            <br><b>收件人：</b><span id="to">Dmitry Baryshkov</span>
            
        </div><br>
        <div id="content"><div class="viewer_part"><div><br><br>On 6/21/2022 10:49 AM, Dmitry Baryshkov wrote:<br>> On Tue, 21 Jun 2022 at 20:44, Abhinav Kumar<quic_abhinavk@quicinc.com>wrote:<br>>><br>>> Copying freedreno<br>> <br>> The patch needs to be sent to freedreno@. Otherwise it doesn't exist<br>> in patchwork.<br><br>Ack<br><br>Hi Sunliming<br><br>Can you please re-send this and copy freedreno email list along with the <br>Reviewed-by and Reported-by tags which I have given below?<br><br>Thanks<br><br>Abhinav<br><br>> <br>>><br>>> On 6/21/2022 10:42 AM, Abhinav Kumar wrote:<br>>>><br>>>><br>>>> On 6/21/2022 4:06 AM, sunliming wrote:<br>>>>> Fixes the following smatch warning:<br>>>>><br>>>>> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c:261<br>>>>> dpu_encoder_phys_wb_atomic_check() warn: variable dereferenced before<br>>>>> check 'conn_state'<br>>>>><br>>>>> Reported-by: kernel test robot<lkp@intel.com><br>>>>> Signed-off-by: sunliming<sunliming@kylinos.cn><br>>>> Reported-by: Dan Carpenter<dan.carpenter@oracle.com><br>>>> Reviewed-by: Abhinav Kumar<quic_abhinavk@quicinc.com><br>>>><br>>>>> ---<br>>>>>    drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c | 10 +++++-----<br>>>>>    1 file changed, 5 insertions(+), 5 deletions(-)<br>>>>><br>>>>> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c<br>>>>> b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c<br>>>>> index 59da348ff339..0ec809ab06e7 100644<br>>>>> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c<br>>>>> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c<br>>>>> @@ -252,11 +252,6 @@ static int dpu_encoder_phys_wb_atomic_check(<br>>>>>        DPU_DEBUG("[atomic_check:%d, \"%s\",%d,%d]\n",<br>>>>>                phys_enc->wb_idx, mode->name, mode->hdisplay,<br>>>>> mode->vdisplay);<br>>>>> -    if (!conn_state->writeback_job || !conn_state->writeback_job->fb)<br>>>>> -        return 0;<br>>>>> -<br>>>>> -    fb = conn_state->writeback_job->fb;<br>>>>> -<br>>>>>        if (!conn_state || !conn_state->connector) {<br>>>>>            DPU_ERROR("invalid connector state\n");<br>>>>>            return -EINVAL;<br>>>>> @@ -267,6 +262,11 @@ static int dpu_encoder_phys_wb_atomic_check(<br>>>>>            return -EINVAL;<br>>>>>        }<br>>>>> +    if (!conn_state->writeback_job || !conn_state->writeback_job->fb)<br>>>>> +        return 0;<br>>>>> +<br>>>>> +    fb = conn_state->writeback_job->fb;<br>>>>> +<br>>>>>        DPU_DEBUG("[fb_id:%u][fb:%u,%u]\n", fb->base.id,<br>>>>>                fb->width, fb->height);<br>> <br>> <br>> <br></quic_abhinavk@quicinc.com></dan.carpenter@oracle.com></sunliming@kylinos.cn></lkp@intel.com></quic_abhinavk@quicinc.com></div></div></div></div>