[FriBidi] Mac OS X
Behdad Esfahbod
behdad at behdad.org
Thu Aug 9 16:35:15 PDT 2007
Ok, found the bug. The bug has been there since forever, in the caprtl
code. It's that the code was not zeroing a malloc'ed block but assuming
that it's zero. It just started manifesting in 0.10.8 because I started
using MALLOC_PERTURB_ recently.
Anyway, here is the patch:
diff -u -p -d -r1.15.2.3 fribidi_char_sets_cap_rtl.c
--- fribidi_char_sets_cap_rtl.c 7 Jun 2005 13:37:31 -0000 1.15.2.3
+++ fribidi_char_sets_cap_rtl.c 9 Aug 2007 23:32:45 -0000
@@ -262,7 +262,7 @@ fribidi_char_set_enter_cap_rtl (void)
int i, count;
caprtl_to_unicode =
- (FriBidiChar *) malloc (CAPRTL_CHARS * sizeof caprtl_to_unicode[0]);
+ (FriBidiChar *) calloc (CAPRTL_CHARS, sizeof (caprtl_to_unicode[0]));
for (i = 0; i < FRIBIDI_TYPES_COUNT; i++)
request[i] = 0;
for (i = 0; i < CAPRTL_CHARS; i++)
cvs diff: Diffing conformance
Making a release.
behdad
On Thu, 2007-08-09 at 16:55 +0300, Baruch Even wrote:
> What I saw is that the output file that is compared with is empty in the
> distribution.
>
> I might be wrong though.
>
> Baruch
>
> * Behdad Esfahbod <behdad at behdad.org> [070809 03:29]:
> >
> > Does anyone feel like debugging what's going on? From what I see the
> > it's just the CapRTL charset failing.
> >
> > behdad
> >
> > On Tue, 2007-08-07 at 14:26 +0200, Till Vollmer wrote:
> > > Also on Linux I get the same:
> > >
> > >
> > > www:~/install/fribidi-0.10.8 # ./run.tests
> > > === test_CapRTL_explicit === 1,14c1,14
> > > < this is _LJUST_o => this is JUST
> > > < a _lsimple _RteST_o th_oat => a simple TSet that
> > > < HAS A _LPDF missing => PDF missing
> > > A SAH
> > > < AnD hOw_L AbOuT, 123,987 tHiS_o => w AbOuT, 123,987
> > > tHiSOh DnA
> > > < a GOOD - _L_oTEST. => a TSET - DOOG.
> > > < here_L is_o_o_o _R a good one_o => here is eno doog a
> > > < And _r 123,987_LTHE_R next_o oNE: => 987THEtxen
> > > oNE:,123 ndA
> > > < _R_r and the last _LONE_o IS => SI and the last ONE
> > > < THE _rbest _lONE and => best ENO
> > > and EHT
> > > < A REAL BIG_l_o BUG! => !GUB GIB
> > > LAER A
> > > < a
> > > _L_L_L_L_L_L_L_L_L_L_L_L_L_L_L_L_L_L_L_L_L_L_L_L_L_L_L_L_L_L_L_Rbug =>
> > > a gub
> > > < AN ARABIC _l_o 123-456 NICE ONE! => !ENO ECIN 456-123
> > > CIBARA NA
> > > < AN ARABIC _l _o 123-456 PAIR => RIAP 123-456
> > > CIBARA NA
> > > < this bug 67_r_o89 catched! => this bug 6789 catched!
> > > ---
> > > > this is _LJUST_o =>
> > > > a _lsimple _RteST_o th_oat =>
> > > > HAS A _LPDF missing =>
> > > > AnD hOw_L AbOuT, 123,987 tHiS_o =>
> > > > a GOOD - _L_oTEST. =>
> > > > here_L is_o_o_o _R a good one_o =>
> > > > And _r 123,987_LTHE_R next_o oNE: =>
> > > > _R_r and the last _LONE_o IS =>
> > > > THE _rbest _lONE and =>
> > > > A REAL BIG_l_o BUG! =>
> > > > a
> > > _L_L_L_L_L_L_L_L_L_L_L_L_L_L_L_L_L_L_L_L_L_L_L_L_L_L_L_L_L_L_L_Rbug
> > > =>
> > > > AN ARABIC _l_o 123-456 NICE ONE! =>
> > > > AN ARABIC _l _o 123-456 PAIR =>
> > > > this bug 67_r_o89 catched! =>
> > > [Failed]
> > > === test_CapRTL_implicit === 1,26c1,26
> > > < car is THE CAR in arabic => car is RAC EHT in arabic
> > > < CAR IS the car IN ENGLISH => HSILGNE NI the car
> > > SI RAC
> > > < he said "IT IS 123, 456, OK" => he said "KO ,456 ,123 SI TI"
> > > < he said "IT IS (123, 456), OK" => he said "KO ,(456 ,123) SI
> > > TI"
> > > < he said "IT IS 123,456, OK" => he said "KO ,123,456 SI TI"
> > > < he said "IT IS (123,456), OK" => he said "KO ,(123,456) SI TI"
> > > < HE SAID "it is 123, 456, ok" => "ok ,it is 123, 456"
> > > DIAS EH
> > > < he said "IT IS 789, 678, OK" => he said "KO ,678 ,789 SI TI"
> > > < he said "IT IS (789, 678), OK" => he said "KO ,(678 ,789) SI
> > > TI"
> > > < he said "IT IS 789,678, OK" => he said "KO ,789,678 SI TI"
> > > < he said "IT IS (789,678), OK" => he said "KO ,(789,678) SI TI"
> > > < HE SAID "it is 789, 678, ok" => "ok ,678 ,789 it is"
> > > DIAS EH
> > > < <H123>shalom</H123> =>
> > > <123H/>shalom<123H>
> > > < <h123>SALAAM</h123> => <h123>MAALAS</h123>
> > > < HE SAID "it is a car!" AND RAN => NAR DNA "!it is a car"
> > > DIAS EH
> > > < HE SAID "it is a car!_>" AND RAN => NAR DNA "it is a car!"
> > > DIAS EH
> > > < -2 CELSIUS IS COLD => DLOC SI
> > > SUISLEC 2-
> > > < SOLVE 1*5 1-5 1/5 1+5 => 5+1 5/1 5-1 5*1
> > > EVLOS
> > > < THE RANGE IS 2.5..5 => 5..2.5 SI
> > > EGNAR EHT
> > > < IOU $10 =>
> > > $10 UOI
> > > < CHANGE -10% => %10-
> > > EGNAHC
> > > < -10% CHANGE =>
> > > EGNAHC %10-
> > > < A TEST FOR WEAK TYPES: 123+,456 => 456,123+ :SEPYT KAEW ROF
> > > TSET A
> > > < ANOTHER FOR WEAK TYPES: A123,456 => 123,456A :SEPYT KAEW ROF
> > > REHTONA
> > > < MORE WEAK TYPES: hooloo123,456 => hooloo123,456 :SEPYT
> > > KAEW EROM
> > > < and TEST|L1 ||too => and TSET|1L ||too
> > > ---
> > > > car is THE CAR in arabic =>
> > > > CAR IS the car IN ENGLISH =>
> > > > he said "IT IS 123, 456, OK" =>
> > > > he said "IT IS (123, 456), OK" =>
> > > > he said "IT IS 123,456, OK" =>
> > > > he said "IT IS (123,456), OK" =>
> > > > HE SAID "it is 123, 456, ok" =>
> > > > he said "IT IS 789, 678, OK" =>
> > > > he said "IT IS (789, 678), OK" =>
> > > > he said "IT IS 789,678, OK" =>
> > > > he said "IT IS (789,678), OK" =>
> > > > HE SAID "it is 789, 678, ok" =>
> > > > <H123>shalom</H123> => <
> > > > <h123>SALAAM</h123> => <
> > > > HE SAID "it is a car!" AND RAN =>
> > > > HE SAID "it is a car!_>" AND RAN =>
> > > > -2 CELSIUS IS COLD =>
> > > > SOLVE 1*5 1-5 1/5 1+5 =>
> > > > THE RANGE IS 2.5..5 =>
> > > > IOU $10 =>
> > > > CHANGE -10% =>
> > > > -10% CHANGE =>
> > > > A TEST FOR WEAK TYPES: 123+,456 =>
> > > > ANOTHER FOR WEAK TYPES: A123,456 =>
> > > > MORE WEAK TYPES: hooloo123,456 =>
> > > > and TEST|L1 ||too =>
> > > [Failed]
> > > === test_ISO8859-8_hebrew === [Passed]
> > > === test_UTF-8_persian === [Passed]
> > >
> > > Am 07.08.2007 um 14:19 schrieb Till Vollmer:
> > >
> > > > Hello,
> > > >
> > > >
> > > > I was able to compile fribidi on Mac OS X 10.4.10 but if I run the
> > > > tests (with run.tests) and get some errors. Any clues?
> > > > Regards
> > > > Till
> > > >
> > > >
> > > >
> > > >
> > > > === test_CapRTL_explicit === 1,14c1,14
> > > > < this is _LJUST_o => this is JUST
> > > > < a _lsimple _RteST_o th_oat => a simple TSet that
> > > > < HAS A _LPDF missing => PDF
> > > > missing A SAH
> > > > < AnD hOw_L AbOuT, 123,987 tHiS_o => w AbOuT, 123,987
> > > > tHiSOh DnA
> > > > < a GOOD - _L_oTEST. => a TSET - DOOG.
> > > > < here_L is_o_o_o _R a good one_o => here is eno doog a
> > > > < And _r 123,987_LTHE_R next_o oNE: => 987THEtxen
> > > > oNE:,123 ndA
> > > > < _R_r and the last _LONE_o IS => SI and the last ONE
> > > > < THE _rbest _lONE and => best ENO
> > > > and EHT
> > > > < A REAL BIG_l_o BUG! => !GUB
> > > > GIB LAER A
> > > > < a
> > > > _L_L_L_L_L_L_L_L_L_L_L_L_L_L_L_L_L_L_L_L_L_L_L_L_L_L_L_L_L_L_L_Rbug
> > > > => a gub
> > > > < AN ARABIC _l_o 123-456 NICE ONE! => !ENO ECIN 456-123
> > > > CIBARA NA
> > > > < AN ARABIC _l _o 123-456 PAIR => RIAP 123-456
> > > > CIBARA NA
> > > > < this bug 67_r_o89 catched! => this bug 6789 catched!
> > > > ---
> > > > > this is _LJUST_o =>
> > > > > a _lsimple _RteST_o th_oat =>
> > > > > HAS A _LPDF missing =>
> > > > > AnD hOw_L AbOuT, 123,987 tHiS_o =>
> > > > > a GOOD - _L_oTEST. =>
> > > > > here_L is_o_o_o _R a good one_o =>
> > > > > And _r 123,987_LTHE_R next_o oNE: =>
> > > > > _R_r and the last _LONE_o IS =>
> > > > > THE _rbest _lONE and =>
> > > > > A REAL BIG_l_o BUG! =>
> > > > > a
> > > > _L_L_L_L_L_L_L_L_L_L_L_L_L_L_L_L_L_L_L_L_L_L_L_L_L_L_L_L_L_L_L_Rbug
> > > > =>
> > > > > AN ARABIC _l_o 123-456 NICE ONE! =>
> > > > > AN ARABIC _l _o 123-456 PAIR =>
> > > > > this bug 67_r_o89 catched! =>
> > > > [Failed]
> > > > === test_CapRTL_implicit === 1,26c1,26
> > > > < car is THE CAR in arabic => car is RAC EHT in arabic
> > > > < CAR IS the car IN ENGLISH => HSILGNE NI the
> > > > car SI RAC
> > > > < he said "IT IS 123, 456, OK" => he said "KO ,456 ,123 SI
> > > > TI"
> > > > < he said "IT IS (123, 456), OK" => he said "KO ,(456 ,123) SI
> > > > TI"
> > > > < he said "IT IS 123,456, OK" => he said "KO ,123,456 SI TI"
> > > > < he said "IT IS (123,456), OK" => he said "KO ,(123,456) SI
> > > > TI"
> > > > < HE SAID "it is 123, 456, ok" => "ok ,it is 123, 456"
> > > > DIAS EH
> > > > < he said "IT IS 789, 678, OK" => he said "KO ,678 ,789 SI
> > > > TI"
> > > > < he said "IT IS (789, 678), OK" => he said "KO ,(678 ,789) SI
> > > > TI"
> > > > < he said "IT IS 789,678, OK" => he said "KO ,789,678 SI TI"
> > > > < he said "IT IS (789,678), OK" => he said "KO ,(789,678) SI
> > > > TI"
> > > > < HE SAID "it is 789, 678, ok" => "ok ,678 ,789 it is"
> > > > DIAS EH
> > > > < <H123>shalom</H123> =>
> > > > <123H/>shalom<123H>
> > > > < <h123>SALAAM</h123> => <h123>MAALAS</h123>
> > > > < HE SAID "it is a car!" AND RAN => NAR DNA "!it is a car"
> > > > DIAS EH
> > > > < HE SAID "it is a car!_>" AND RAN => NAR DNA "it is a car!"
> > > > DIAS EH
> > > > < -2 CELSIUS IS COLD => DLOC SI
> > > > SUISLEC 2-
> > > > < SOLVE 1*5 1-5 1/5 1+5 => 5+1 5/1 5-1
> > > > 5*1 EVLOS
> > > > < THE RANGE IS 2.5..5 => 5..2.5 SI
> > > > EGNAR EHT
> > > > < IOU $10 =>
> > > > $10 UOI
> > > > < CHANGE -10% => %
> > > > 10- EGNAHC
> > > > < -10% CHANGE =>
> > > > EGNAHC %10-
> > > > < A TEST FOR WEAK TYPES: 123+,456 => 456,123+ :SEPYT KAEW
> > > > ROF TSET A
> > > > < ANOTHER FOR WEAK TYPES: A123,456 => 123,456A :SEPYT KAEW ROF
> > > > REHTONA
> > > > < MORE WEAK TYPES: hooloo123,456 => hooloo123,456 :SEPYT
> > > > KAEW EROM
> > > > < and TEST|L1 ||too => and TSET|1L ||too
> > > > ---
> > > > > car is THE CAR in arabic =>
> > > > > CAR IS the car IN ENGLISH =>
> > > > > he said "IT IS 123, 456, OK" =>
> > > > > he said "IT IS (123, 456), OK" =>
> > > > > he said "IT IS 123,456, OK" =>
> > > > > he said "IT IS (123,456), OK" =>
> > > > > HE SAID "it is 123, 456, ok" =>
> > > > > he said "IT IS 789, 678, OK" =>
> > > > > he said "IT IS (789, 678), OK" =>
> > > > > he said "IT IS 789,678, OK" =>
> > > > > he said "IT IS (789,678), OK" =>
> > > > > HE SAID "it is 789, 678, ok" =>
> > > > > <H123>shalom</H123> => <
> > > > > <h123>SALAAM</h123> => <
> > > > > HE SAID "it is a car!" AND RAN =>
> > > > > HE SAID "it is a car!_>" AND RAN =>
> > > > > -2 CELSIUS IS COLD =>
> > > > > SOLVE 1*5 1-5 1/5 1+5 =>
> > > > > THE RANGE IS 2.5..5 =>
> > > > > IOU $10 =>
> > > > > CHANGE -10% =>
> > > > > -10% CHANGE =>
> > > > > A TEST FOR WEAK TYPES: 123+,456 =>
> > > > > ANOTHER FOR WEAK TYPES: A123,456 =>
> > > > > MORE WEAK TYPES: hooloo123,456 =>
> > > > > and TEST|L1 ||too =>
> > > > [Failed]
> > > > === test_ISO8859-8_hebrew === [Passed]
> > > > === test_UTF-8_persian === [Passed]
> > > >
> > > >
> > > >
> > > > Codemart GmbH
> > > > Till Vollmer
> > > > Managing Director
> > > > Tel: +49 (0)89 1213 5359
> > > > Mob: + 49 (0)160 718 7403
> > > > Fax: +49 (0)89 1892 1347
> > > > Yahoo ID: till_vollmer
> > > > Skype: till_vollmer
> > > > www.codemart.de
> > > > till.vollmer at codemart.de
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > >
> > > Codemart GmbH
> > > Till Vollmer
> > > Managing Director
> > > Tel: +49 (0)89 1213 5359
> > > Mob: + 49 (0)160 718 7403
> > > Fax: +49 (0)89 1892 1347
> > > Yahoo ID: till_vollmer
> > > Skype: till_vollmer
> > > www.codemart.de
> > > till.vollmer at codemart.de
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > > _______________________________________________
> > > fribidi mailing list
> > > fribidi at lists.freedesktop.org
> > > http://lists.freedesktop.org/mailman/listinfo/fribidi
> > --
> > behdad
> > http://behdad.org/
> >
> > "Those who would give up Essential Liberty to purchase a little
> > Temporary Safety, deserve neither Liberty nor Safety."
> > -- Benjamin Franklin, 1759
> >
> >
> >
> > _______________________________________________
> > fribidi mailing list
> > fribidi at lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/fribidi
>
> Cheers,
> Baruch
--
behdad
http://behdad.org/
"Those who would give up Essential Liberty to purchase a little
Temporary Safety, deserve neither Liberty nor Safety."
-- Benjamin Franklin, 1759
More information about the fribidi
mailing list