[FriBidi] [Bug 191241] Re: New upstream version 0.19.2

[Behdad Esfahbod]

Thanks Ahmed.  My comments below:

On 01/11/2010 11:22 AM, أحمد المحمودي wrote:
> On Mon, Jan 11, 2010 at 11:18:56AM -0000, Daniel Holbach wrote:
>> Check the list of rdepends, get the source and grep -r for the function
>> names that were removed between versions.
> ---end quoted text---
> 
> For all packages in Debian unstable (sid) that depend on libfribidi0, I 
> grep'ed for the symbols removed in 0.19.2. I found that 5 packages do 
> use some of the removed symbols. I've attached the grep result with this 
> email.
> 
> To summarize:
> 
> * bidiv & centerim use: fribidi_iso8859_8_to_unicode_c, fribidi_unicode_to_iso8859_8

Both should be trivial to patch.

> * quesoglc uses: nFriBidiMirroredChars, fribidi_prop_to_type

Apparently quesoglc includes a *copy* of FriBidi in its source tree.  So that
doesn't count.

> * mailutils uses fribidi_wcwidth provided that HAVE_FRIBIDI_WCWIDTH is 
>   defined, I grep'ed for HAVE_FRIBIDI_WCWIDTH in both 0.19.2 & 0.10.9 
>   and I didn't find that

You later said this one compiles with latest version.  So, good?

> * text-bidi, which is a perl interface for libfribidi, uses many of 
>   those obsolete symbols of fribidi, yet declares them to be "private".

If it's bindings, can simply be updated.


> So to conclude, I see two solutions:
>
> 1) That Debian/Ubuntu do as Fedora, and patch the few apps (probably
> only bidiv & centerim will need patching) that use obsolete fribidi
> symbols. Note that centerim will also need a small patch very similar to
> the one used for bidiv. Also if fribidi is to be backported to older
> releases, then mailutils will need to be patched too.

This is what I suggest.


> 2) Fribidi would SO bump.

Then you have to rebuild all the apps that use the mainstream fribidi API.
The reason I did not bump the .so version was such that the new version is a
drop-in replacement of the old series that adds Arabic shaping.  And many
mplayer users appreciate that...


behdad