[FriBidi] Incorrect Arabic text rendering in maperver

[Ian Walberg]

Behdad,

We are back looking at this again and have tried a few combinations and none seem to work.

Here is the test change we made to fribidi-arabic.c

for (i = 0; i < len - 1; i++) {
    register FriBidiChar c;
    if (FRIBIDI_LEVEL_IS_RTL(embedding_levels[i]) &&
        embedding_levels[i] == embedding_levels[i+1] &&
        (c = PAIR_MATCH(table, size, str[i], str[i+1])))
      {
        /* str[i] = FRIBIDI_CHAR_FILL; */
// Do we need to remove this next line as well?
        FRIBIDI_SET_BITS(ar_props[i], FRIBIDI_MASK_LIGATURED);
        /* str[i+1] = c; */
        str[i] = c;
      }
  }

The assumption is that we would make the 'real' change to mapserver and not here.

Thanks

Ian

-----Original Message-----
From: Behdad Esfahbod [mailto:behdad.esfahbod at gmail.com] On Behalf Of Behdad Esfahbod
Sent: Wednesday, January 19, 2011 7:01 AM
To: Ian Walberg
Cc: Stephen Woodbridge; fribidi at lists.freedesktop.org
Subject: Re: [FriBidi] Incorrect Arabic text rendering in maperver

On 01/18/11 01:09, Ian Walberg wrote:
> Behdad,
> 
> I have taken a look at the code and from what I can see the relavant part of the code is below.

Correct.

> Can I make a test modification to this to test the cause of the problem?

Sure you can :).

behdad

> Thanks
> 
> Ian
>