[Galago-commits] r2937 - in trunk/libnotify: . libnotify

[galago-commits at freedesktop.org]

Author: chipx86
Date: 2006-11-05 12:07:37 -0800 (Sun, 05 Nov 2006)
New Revision: 2937

Modified:
   trunk/libnotify/ChangeLog
   trunk/libnotify/NEWS
   trunk/libnotify/libnotify/notify.c
Log:
Patch by Giacomo Lozito to fix a problem where the dbus proxy was not being freed on notify_uninit, which led to problems when libnotify was used in a loadable module. This fixes bug #92.


Modified: trunk/libnotify/ChangeLog
===================================================================
--- trunk/libnotify/ChangeLog	2006-11-05 19:54:20 UTC (rev 2936)
+++ trunk/libnotify/ChangeLog	2006-11-05 20:07:37 UTC (rev 2937)
@@ -1,3 +1,10 @@
+Sun Nov 05 12:06:01 PST 2006  Christian Hammond <chipx86 at chipx86.com>
+
+	* libnotify/notify.c:
+	  - Patch by Giacomo Lozito to fix a problem where the dbus proxy was
+	    not being freed on notify_uninit, which led to problems when libnotify
+	    was used in a loadable module. This fixes bug #92.
+
 Sun Nov 05 11:54:10 PST 2006  Christian Hammond <chipx86 at chipx86.com>
 
 	* configure.ac:

Modified: trunk/libnotify/NEWS
===================================================================
--- trunk/libnotify/NEWS	2006-11-05 19:54:20 UTC (rev 2936)
+++ trunk/libnotify/NEWS	2006-11-05 20:07:37 UTC (rev 2937)
@@ -1,6 +1,8 @@
 version 0.4.4:
 	* Fixed a bug where a notification's ID could be reset when a different
 	  notification was closed. Patch by jylefort. (Bug #94)
+	* Fixed a crash when the D-BUS proxy was not being freed on notify_uninit,
+	  which was problematic when used in a loadable module. (Bug #92)
 
 version 0.4.3 (8-October-2006):
 	* Fixed the raw image data support to send the correct array type.

Modified: trunk/libnotify/libnotify/notify.c
===================================================================
--- trunk/libnotify/libnotify/notify.c	2006-11-05 19:54:20 UTC (rev 2936)
+++ trunk/libnotify/libnotify/notify.c	2006-11-05 20:07:37 UTC (rev 2937)
@@ -120,6 +120,9 @@
 {
 	GList *l;
 
+	if (!_initted)
+		return;
+
 	if (_app_name != NULL)
 	{
 		g_free(_app_name);
@@ -137,6 +140,8 @@
 		}
 	}
 
+	g_object_unref(_proxy);
+
 	_initted = FALSE;
 }