[Galago-commits] r2994 - in trunk/notification-daemon: . src/daemon

[galago-commits at freedesktop.org]

Author: chipx86
Date: 2007-08-25 19:38:01 -0700 (Sat, 25 Aug 2007)
New Revision: 2994

Modified:
   trunk/notification-daemon/ChangeLog
   trunk/notification-daemon/NEWS
   trunk/notification-daemon/src/daemon/daemon.c
Log:
Show notifications if a fullscreen window isn't the active window.  This fixes problems if a fullscreen window is hidden or minimized.  This fixes bug #142.


Modified: trunk/notification-daemon/ChangeLog
===================================================================
--- trunk/notification-daemon/ChangeLog	2007-08-26 02:11:23 UTC (rev 2993)
+++ trunk/notification-daemon/ChangeLog	2007-08-26 02:38:01 UTC (rev 2994)
@@ -1,3 +1,10 @@
+Sat Aug 25 19:31:16 PDT 2007  Christian Hammond <chipx86 at chipx86.com>
+
+	* src/daemon/daemon.c:
+	  - Show notifications if a fullscreen window isn't the active window.
+	    This fixes problems if a fullscreen window is hidden or minimized.
+	    This fixes bug #142.
+
 Sat Aug 25 19:10:18 PDT 2007  Christian Hammond <chipx86 at chipx86.com>
 
 	* src/themes/standard/theme.c:

Modified: trunk/notification-daemon/NEWS
===================================================================
--- trunk/notification-daemon/NEWS	2007-08-26 02:11:23 UTC (rev 2993)
+++ trunk/notification-daemon/NEWS	2007-08-26 02:38:01 UTC (rev 2994)
@@ -12,6 +12,8 @@
 	  notification theme and popup positions. Patch by John Wendell.
 	  (Ticket #126)
 	* Added an Arabic translation. Patch by Djihed Afifi. (Ticket #131)
+	* Fixed a bug where notifications weren't displayed if a fullscreen
+	  window was minimized. (Bug #142)
 	* Fixed a bug where we were quitting on theme engine failure, instead of
 	  falling back to the default theme engine. Patch by
 	  driehuis-at-playbeing.org. (Ticket #128)
@@ -20,6 +22,8 @@
 	  (Bug #5)
 	* Fixed the close button size on the notifications so that they don't
 	  stretch. Patch by Luca Cavelli. (Bug #127)
+	* Fixed a crash when an unsupported value type was passed in for the
+	  urgency when using the standard theme. (Bug #135)
 
 version 0.3.7 (27-February-2007):
 	* Fixed a compatibility issue with dbus-glib 0.72. Patch by Pawel Worach.

Modified: trunk/notification-daemon/src/daemon/daemon.c
===================================================================
--- trunk/notification-daemon/src/daemon/daemon.c	2007-08-26 02:11:23 UTC (rev 2993)
+++ trunk/notification-daemon/src/daemon/daemon.c	2007-08-26 02:38:01 UTC (rev 2994)
@@ -796,7 +796,8 @@
 	{
 		WnckWindow *wnck_win = (WnckWindow *)l->data;
 
-		if (wnck_window_is_fullscreen(wnck_win))
+		if (wnck_window_is_fullscreen(wnck_win) &&
+			wnck_window_is_active(wnck_win))
 		{
 			/*
 			 * Sanity check if the window is _really_ fullscreen to