[Galago-commits] r2964 - in trunk/libnotify: . docs/reference/tmpl libnotify

[galago-commits at freedesktop.org]

Author: chipx86
Date: 2007-02-15 00:54:39 -0800 (Thu, 15 Feb 2007)
New Revision: 2964

Modified:
   trunk/libnotify/ChangeLog
   trunk/libnotify/docs/reference/tmpl/notification.sgml
   trunk/libnotify/libnotify/notification.c
Log:
Fix a bug in notify_notification_add_action where the function to free the user data was never called, causing memory leaks.  This fixes bug #119.


Modified: trunk/libnotify/ChangeLog
===================================================================
--- trunk/libnotify/ChangeLog	2007-01-13 09:20:46 UTC (rev 2963)
+++ trunk/libnotify/ChangeLog	2007-02-15 08:54:39 UTC (rev 2964)
@@ -1,3 +1,10 @@
+Thu Feb 15 00:52:56 PST 2007  Christian Hammond <chipx86 at chipx86.com>
+
+	* libnotify/notification.c:
+	  - Fix a bug in notify_notification_add_action where the function
+	    to free the user data was never called, causing memory leaks.
+	    This fixes bug #119.
+
 Mon Nov 13 23:42:07 PST 2006  Christian Hammond <chipx86 at chipx86.com>
 
 	* tests/Makefile.am:

Modified: trunk/libnotify/docs/reference/tmpl/notification.sgml
===================================================================
--- trunk/libnotify/docs/reference/tmpl/notification.sgml	2007-01-13 09:20:46 UTC (rev 2963)
+++ trunk/libnotify/docs/reference/tmpl/notification.sgml	2007-02-15 08:54:39 UTC (rev 2964)
@@ -66,6 +66,11 @@
 
 </para>
 
+<!-- ##### ARG NotifyNotification:status-icon ##### -->
+<para>
+
+</para>
+
 <!-- ##### ARG NotifyNotification:summary ##### -->
 <para>
 

Modified: trunk/libnotify/libnotify/notification.c
===================================================================
--- trunk/libnotify/libnotify/notification.c	2007-01-13 09:20:46 UTC (rev 2963)
+++ trunk/libnotify/libnotify/notification.c	2007-02-15 08:54:39 UTC (rev 2964)
@@ -1195,6 +1195,7 @@
 	pair = g_new0(CallbackPair, 1);
 	pair->cb = callback;
 	pair->user_data = user_data;
+	pair->free_func = free_func;
 	g_hash_table_insert(priv->action_map, g_strdup(action), pair);
 
 	if (notification->priv->has_nondefault_actions &&