[Galago-commits] r2971 - in trunk/notification-daemon: . src/daemon

[galago-commits at freedesktop.org]

Author: chipx86
Date: 2007-02-15 03:07:09 -0800 (Thu, 15 Feb 2007)
New Revision: 2971

Modified:
   trunk/notification-daemon/ChangeLog
   trunk/notification-daemon/NEWS
   trunk/notification-daemon/src/daemon/stack.c
Log:
Fix a memory leak when removing a notification from the stack.  Patch by Sven Wegener. This closes bug #105.


Modified: trunk/notification-daemon/ChangeLog
===================================================================
--- trunk/notification-daemon/ChangeLog	2007-02-15 11:03:43 UTC (rev 2970)
+++ trunk/notification-daemon/ChangeLog	2007-02-15 11:07:09 UTC (rev 2971)
@@ -1,3 +1,10 @@
+Thu Feb 15 03:05:49 PST 2007  Christian Hammond <chipx86 at chipx86.com>
+
+	* src/daemon/stack.c:
+	* NEWS:
+	  - Fix a memory leak when removing a notification from the stack.
+	    Patch by Sven Wegener. This closes bug #105.
+
 Thu Feb 15 02:52:02 PST 2007  Christian Hammond <chipx86 at chipx86.com>
 
 	* po/ChangeLog:

Modified: trunk/notification-daemon/NEWS
===================================================================
--- trunk/notification-daemon/NEWS	2007-02-15 11:03:43 UTC (rev 2970)
+++ trunk/notification-daemon/NEWS	2007-02-15 11:07:09 UTC (rev 2971)
@@ -5,6 +5,8 @@
 	  transparent when compiled against GTK+ 2.10 and when using a composite
 	  manager. Patch by Matt Walton. (Ticket #110)
 	* Fix several rendering glitches with the borders in the standard theme.
+	* Fix a memory leak when removing a notification. Patch by Sven Wegener.
+	  (Bug #105).
 	* Added initial accessibility support with the standard theme engine.
 	* Clicking anywhere in a notification should now close the notification.
 	  This was happening only on the body text sometimes.

Modified: trunk/notification-daemon/src/daemon/stack.c
===================================================================
--- trunk/notification-daemon/src/daemon/stack.c	2007-02-15 11:03:43 UTC (rev 2970)
+++ trunk/notification-daemon/src/daemon/stack.c	2007-02-15 11:07:09 UTC (rev 2971)
@@ -271,7 +271,7 @@
 	notify_stack_shift_notifications(stack, nw, &remove_l, 0, 0, NULL, NULL);
 
 	if (remove_l != NULL)
-		stack->windows = g_slist_remove_link(stack->windows, remove_l);
+		stack->windows = g_slist_delete_link(stack->windows, remove_l);
 
 	if (GTK_WIDGET_REALIZED(GTK_WIDGET(nw)))
 		gtk_widget_unrealize(GTK_WIDGET(nw));