[Glamor] [PATCH 1/9] glamor-composite: Optimize the computation of composite region.

[Zhigang Gong]

> -----Original Message-----
> From:
> glamor-bounces+zhigang.gong=linux.intel.com at lists.freedesktop.org
> [mailto:glamor-bounces+zhigang.gong=linux.intel.com at lists.freedesktop.o
> rg] On Behalf Of Chris Wilson
> Sent: Monday, January 09, 2012 6:23 PM
> To: zhigang.gong at linux.intel.com; glamor at lists.freedesktop.org
> Cc: zhigang.gong at linux.intel.com; junyan.he at intel.com;
> boqun.feng at gmail.com; nanhai.zou at intel.com; zhigang.gong at gmail.com
> Subject: Re: [Glamor] [PATCH 1/9] glamor-composite: Optimize the
> computation of composite region.
> 
> I had a cursory read through of the series and agree wholeheartedly with
> the changelogs -- just haven't analysed the actual changes to see if they
> match with the intent. :)
> 
> Before I do, can you also consider adding glFinish to
> glamor_block_handler(). If you start using firefxo, you will notice that
it
> can get quite laggy (and will become more apparent as you reduce the
> overheads) - a sign that we are not throttling correctly. 

I agree to add glFinish there. And a short test shows, it will not hurt
performance.
But I can't reproduce the laggy symptom on my machine, don't know whether
this
change can fix that, will submit a patch latter and may need your help to
test it.

> And as with glamor
> we never expect to use the UXA block handler, there is no mechanism for
> ensuring that the scanout gets flushed. I think the UXA blockhandler
> should be run unconditionally just to ensure the regular flush...

Right an unconditional flush the rendering buffer should fix this problem.
I was thinking about can we let the OpenGL to do that flushing internally,
for example
in glFlush. We discussed this issue before, and you told me EGL may don't
support
front buffer flushing at all. I just think is this a problem of EGL, and do
we need to 
add this support to EGL extension? Actually, EGL image and gbm both have
SCANOUT usage bit defined. And can we add a new interface to do a rendering
flush 
on those SCANOUT image? It can take a gbm buffer as input parameter.


> -Chris
> 
> --
> Chris Wilson, Intel Open Source Technology Centre
> _______________________________________________
> Glamor mailing list
> Glamor at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/glamor