[Glamor] [PATCH 0/3] Add the feature for trapezoid render using shader.

Zhigang Gong zhigang.gong at linux.intel.com
Tue Jun 12 04:21:54 PDT 2012


Junyan,

I merged trapezoid with largepixmap branch, and put it at
 git://people.freedesktop.org/~gongzg/glamor merge_trapezoid

I haven't add large pixmap support to trapezoid, but fallback to previous
Implementation if the src or dest is large pixmap.

I did a quick test on it, and found one obvious corrupt rendering result
with
./cairo-test-suite unantialiased-shapes

And another case also need further investigation, the rendering result is
not correct and is not a numeric noise.
./cairo-test-suite a1-clip-fill-rule

You can reproduce the above two cases on this merged cases. And I also
tried your branch and the symptom is the same. So please work on this
merged branch directly.

As to the trapezoid's large pixmap support, I leave it to you. IMO, It
doesn't
have a very high priority. Bug fix is the first priority.

Thanks.

> -----Original Message-----
> From: Zhigang Gong [mailto:zhigang.gong at linux.intel.com]
> Sent: Monday, June 11, 2012 5:26 PM
> To: 'junyan.he at linux.intel.com'
> Cc: 'RobinHe'; 'glamor at lists.freedesktop.org'
> Subject: RE: [Glamor] [PATCH 0/3] Add the feature for trapezoid render
> using shader.
> 
> I just pushed the stable version of large pixmap branch to
> git://people.freedesktop.org/~gongzg/glamor for_large_pixmap
> 
> Please pull it and try to merge with your latest trapezoid implementation.
> 
> For testing purpose, you can uncomment the following macro defined at
> glamor_priv.h #if 0 #define MAX_FBO_SIZE 32 /* For test purpose only. */
> #endif
> 
> You can choose a proper max fbo size for your cases.
> 
> You can refer the glamor_copyarea to see a simple large pixmap support
> without transform + repeat processing. You can see how to clip on the dest
> pixmap, and then do 2nd round clip on source pixmap and thus can split
> the rendering to small pieces.
> 
> Any question, please let me know. Thanks.
> 
> > -----Original Message-----
> > From:
> > glamor-bounces+zhigang.gong=linux.intel.com at lists.freedesktop.org
> >
> [mailto:glamor-bounces+zhigang.gong=linux.intel.com at lists.freedesktop.
> > o rg] On Behalf Of junyan.he at linux.intel.com
> > Sent: Monday, June 04, 2012 5:08 AM
> > To: zhigang.gong at linux.intel.com
> > Cc: RobinHe; glamor at lists.freedesktop.org
> > Subject: [Glamor] [PATCH 0/3] Add the feature for trapezoid render
> > using shader.
> >
> > From: RobinHe <robinhe at robinhe-desktop.lan>
> >
> >  This serial of patches will add the feature for trapezoid render
> > using shader.
> >  The old manner in glamor uses pixman to generate the trapezoid mask
> > and upload  it to GPU, and then do the compositing to generate the
> > final result.
> >  We use shader to replace pixman to generate the temp trapezoid,
> which
> > will save  the uploading time.
> >
> > Signed-off-by: RobinHe <robinhe at robinhe-desktop.lan>
> >
> > ---
> > src/Makefile.am        |    1 +
> > src/glamor.c           |    6 +
> > src/glamor_gradient.c  |   47 +--
> > src/glamor_priv.h      |   15 +-
> > src/glamor_render.c    |  147 ---------
> > src/glamor_trapezoid.c |  765
> > ++++++++++++++++++++++++++++++++++++++++++++++++
> > src/glamor_utils.h     |   58 ++++
> > 7 files changed, 857 insertions(+), 182 deletions(-)
> > _______________________________________________
> > Glamor mailing list
> > Glamor at lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/glamor



More information about the Glamor mailing list