[Glamor] [PATCH 2/2] glamor_render: Convert 1bpp to 8bpp before uploading.

[zhigang gong]

On Tue, Mar 27, 2012 at 6:38 PM, Chris Wilson <chris at chris-wilson.co.uk> wrote:
> On Tue, 27 Mar 2012 14:14:05 +0800, zhigang.gong at linux.intel.com wrote:
>> From: Zhigang Gong <zhigang.gong at linux.intel.com>
>>
>> Then we can avoid the extremely fallback path.
>
> Isn't this just a workaround for lack of GL_BITMAP handling in the code
> for uploads of PICT_a1? We could pass the bitmap straight to the driver,
> at the minimum it should do the conversion inline.
Yes, it's such a workaround.
As the GLES2 doesn't support GL_BITMAP, I haven't use it at the
uploading function.
But I agree, it will be more useful to add PICT_a1 uploading at the uploading
function rather than only at the composite function.  Will refine this patch
to use GL_BITMAP directly for OpenGL and a workaround version for GLES2.

> -Chris
>
> --
> Chris Wilson, Intel Open Source Technology Centre