[Glamor] [PATCH v3] Add DRI3 support to glamor

[davyaxel at free.fr]

Thanks for pointing that out.

I've written a protection in case libgbm is missing,
but it's not declenching properly.

I'll post a patch for that in a few hours.

Since you get errors with libgbm too,
that means you can't use DRI3 support in glamor.
You would have to compile with DRI3 support disabled.

Axel Davy


On 07/12/2013, Gaetan Nadon wrote :
> On 13-12-06 11:00 AM, zhigang gong wrote:
>> LGTM, pushed, thanks for your contribution.
>>
>> On Thu, Dec 5, 2013 at 3:49 PM, Axel Davy <axel.davy at ens.fr> wrote:
>>
>>     This implements some DRI3 helpers to help the DDXs using
>>     glamor to support DRI3.
>>
>>     Signed-off-by: Axel Davy <axel.davy at ens.fr>
>>     ---
>>
>
> This patch introduces compile errors.
> I just did a full build of X from git and I get a dozen of errors in glamor_egl.c and a load of warnings.
>
>     With libgbm:
>     ../src/glamor_egl.c:236:45: error: 'GBM_FORMAT_ARGB8888' undeclared (first use in this function)
>     ../src/glamor_egl.c:466:38: error: 'GBM_BO_IMPORT_EGL_IMAGE' undeclared (first use in this function)
>     ../src/glamor_egl.c:543:38: error: 'GBM_BO_IMPORT_EGL_IMAGE' undeclared (first use in this function)
>
>
>     Without libgbm, some more:
>     ../src/glamor_egl.c:236:32: error: 'struct glamor_egl_screen_private' has no member named 'gbm'
>     ../src/glamor_egl.c:237:11: error: 'GBM_BO_USE_RENDERING' undeclared (first use in this function)
>     ../src/glamor_egl.c:238:11: error: 'GBM_BO_USE_SCANOUT' undeclared (first use in this function)
>     ../src/glamor_egl.c:399:1: error: conflicting types for 'glamor_get_fd_from_bo'
>     ../src/glamor_egl.c:401:22: error: storage size of 'handle' isn't known
>     ../src/glamor_egl.c:414:1: error: conflicting types for 'glamor_get_name_from_bo'
>     ../src/glamor_egl.c:416:22: error: storage size of 'handle' isn't known
>     ../src/glamor_egl.c:513:29: error: 'DRM_FORMAT_ARGB8888' undeclared (first use in this function)
>     ../src/glamor_egl.c:543:31: error: 'struct glamor_egl_screen_private' has no member named 'gbm' 
>
>
> When libgbm is missing, either protect the code or make it a requirement in the configuration. It's ok to abort the configuration if an important package is missing. You may want to add more checks if a particular version of libgbm is required.
>
> Here is a snippet of the autoconf configuration.
>
>     ./autogen.sh --prefix $prefix
>     [...]
>     checking for XORG... yes
>     checking for DRI2... yes
>     checking whether to include GLAMOR_GLES2 support... no
>     checking whether to include GLAMOR Xv support... yes
>     checking whether to enable DEBUG... no
>     checking for GL... yes
>     checking for LIBDRM... yes
>     checking for EGL... yes
>     checking for GBM... yes
>     checking Enable Glamor Dri3 helpers... yes
>     checking for thread local storage (TLS) support... __thread
>     checking for tls_model attribute support... yes
>
>
>
>
>
> _______________________________________________
> Glamor mailing list
> Glamor at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/glamor