[Glamor] [PATCH v3] Add DRI3 support to glamor

[davyaxel at free.fr]

On 09/12/2013, Gaetan Nadon wrote :
> On 13-12-09 01:44 PM, davyaxel at free.fr wrote:
>> I don't think we need to expose the gbm_bo content.
>>
>> I found a warning flag: -Wc++-compat,
>>
>> which will warn if we convert a void * to struct gbm_bo*.
>> So if we add to my code "bo = native_pixmap;", and the flag, then the test is complete.
>>
>> However we may have to check the flag is available.
> Symbian uses two version of the GCC compiler (cross-compilers for ARM)
> but I did not find the docs.
>
> In any case, to protect the check, you should test the flags for
> applicability:
>
> In configure.ac:
> XORG_TESTSET_CFLAG([COMPAT_CFLAGS], [-Wc++-compat], [-Werror])
>
> The flags will be added to the variable if they are supported. We never
> know for sure with which compiler our code gets built with. I think this
> is more than reasonable. Others will step-up to handle the few remainder
> cases if any
>
Yep, expect we still have to use -Werror, to have the compilation failing in case there is a warning.

I let you propose your configure.ac changes.

Thanks,

Axel Davy