[Glamor] R: Re: [PATCH v3] Add DRI3 support to glamor

[Fabio Pedretti]

There are some warnings that should be fixed before enabling -Werror for the 
whole project:
http://goo.gl/OyFuks

>----Messaggio originale----
>Da: davyaxel at free.fr
>Data: 09/12/2013 21.59
>A: "Gaetan Nadon"<memsize at videotron.ca>
>Cc: "glamor"<glamor at lists.freedesktop.org>
>Ogg: Re: [Glamor] [PATCH v3] Add DRI3 support to glamor
>
>On 09/12/2013, Gaetan Nadon wrote :
>> On 13-12-09 01:44 PM, davyaxel at free.fr wrote:
>>> I don't think we need to expose the gbm_bo content.
>>>
>>> I found a warning flag: -Wc++-compat,
>>>
>>> which will warn if we convert a void * to struct gbm_bo*.
>>> So if we add to my code "bo = native_pixmap;", and the flag, then the test 
is complete.
>>>
>>> However we may have to check the flag is available.
>> Symbian uses two version of the GCC compiler (cross-compilers for ARM)
>> but I did not find the docs.
>>
>> In any case, to protect the check, you should test the flags for
>> applicability:
>>
>> In configure.ac:
>> XORG_TESTSET_CFLAG([COMPAT_CFLAGS], [-Wc++-compat], [-Werror])
>>
>> The flags will be added to the variable if they are supported. We never
>> know for sure with which compiler our code gets built with. I think this
>> is more than reasonable. Others will step-up to handle the few remainder
>> cases if any
>>
>Yep, expect we still have to use -Werror, to have the compilation failing in 
case there is a warning.
>
>I let you propose your configure.ac changes.
>
>Thanks,
>
>Axel Davy
>_______________________________________________
>Glamor mailing list
>Glamor at lists.freedesktop.org
>http://lists.freedesktop.org/mailman/listinfo/glamor
>