[Glamor] Configuration for DRI3 support preview

[Gaetan Nadon]

On 13-12-16 04:10 PM, davyaxel at free.fr wrote:
> On 16/12/2013, zhigang gong wrote :
>> Right, glamor used to be ported to a PVR platform which is the only
>> non-mesa platform we tried to support. And I don't think that platform
>> will support DRI3 currently. And that platform also doesn't have
>> gbm library.
>> IMO, to make the DRI3 support depend on libgbm version 9 should
>> be good enough currently. I can't think of a case which has libgbm
>> version 9 but has an incompatible EGLNativePixmapType. Is there any
>> of such real case?
>> Thanks,
>> Zhigang Gong.
>>
>>
> Thanks for this explanation.
>
> Is there a good reason for not having the EGLNativePixmapType test?
> Keeping it could help see if an update of Mesa changes EGLNativePixmapType, and then prevent regressions.
Sorry, I had not read your post before I sent v2 of the patch.

Generally speaking I agree with you that such a test is more robust. On
the other hand they are expensive to craft and maintain. They are used
as a last resort when the usual library checks are not sufficient. There
is only so much we can predict regarding the future. It is easy to
add/change/delete the configuration tests.

If mesa decides to change the native type from a gbm_bo struct to
something else, the glamor egl code will have to change anyway as it
will be broken. The configuration will disable dri3 support, if and only
if --enable-glamor-dri3 has not been set to "yes" (e.g. user has type
--enable-glamor-dri3 on the command line). Otherwise the configuration
will stop on error because user requested dri3 support and it was not
possible. This behaviour is missing in glamor configuration right now in
git.

I invite you and Zhigang to try out the v2 patches. There is a choice to
be made for the versions of the libraries to check for.

Thanks.

>
> Gaetan: Your patch is ok for me.
>
> Reviewed-by: Axel Davy <axel.davy at ens.fr>
> _______________________________________________
> Glamor mailing list
> Glamor at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/glamor
>