[Glamor] [PATCH] Autotools fixes

[Armin K.]

On 03/13/2013 09:25 AM, Michel Dänzer wrote:
> On Die, 2013-03-12 at 21:00 +0100, Armin K wrote:
>> * Properly dist all necesary headers.
>> * Shut up automake by changing INCLUDES to AM_CPPFLAGS
>> * Fix libglamoregl.so linking with libglamor.so - use rpath
>
> It would be better to split this up into separate changes.
>

Okay.

>
>> @@ -64,7 +65,7 @@ if EGL
>>   LIBGLAMOREGL = libglamoregl.la
>>   module_LTLIBRARIES = $(LIBGLAMOREGL)
>>   libglamoregl_la_DEPENDENCIES = libglamor.la
>> -libglamoregl_la_LDFLAGS = -avoid-version -module $(EGL_LIBS) -lglamor $(GLX_SYS_LIBS)
>> +libglamoregl_la_LDFLAGS = -avoid-version -module $(EGL_LIBS) -lglamor $(GLX_SYS_LIBS) -Wl,-rpath -Wl,$(moduledir)
>>   libglamoregl_la_SOURCES = glamor_eglmodule.c $(top_srcdir)/src/glamor_egl.c
>>   libglamoregl_la_CFLAGS = $(AM_CFLAGS) $(GLX_DEFINES) -I$(top_srcdir)/src $(LIBDRM_CFLAGS) $(EGL_CFLAGS)
>>   endif
>
> It would be better to just install libglamor to the standard lib
> directory instead of using rpath.
>
>

I was thinking of that, but I wasn't sure if libglamor.so is actualy a 
Xorg module or just a library. Which one is true? If so, I could try to 
hack makefiles to install libglamor.so to /usr/lib and introduce libtool 
versioning. Does that sound okay?