[Gstreamer-bugs] [Bug 100553] New - Incorrect test on valloc return in gst/cothreads.c

[bugzilla-daemon at widget.gnome.org]

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

http://bugzilla.gnome.org/show_bug.cgi?id=100553

Changed by jmi25 at cam.ac.uk.

--- shadow/100553	Fri Dec  6 14:54:12 2002
+++ shadow/100553.tmp.8963	Fri Dec  6 14:54:12 2002
@@ -0,0 +1,34 @@
+Bug#: 100553
+Product: GStreamer
+Version: 0.4.2
+OS: FreeBSD
+OS Details: 4.5-RELEASE-p18 i386
+Status: NEW   
+Resolution: 
+Severity: normal
+Priority: Normal
+Component: gstreamer (core)
+AssignedTo: gstreamer-maint at bugzilla.gnome.org                            
+ReportedBy: jmi25 at cam.ac.uk               
+QAContact: gstreamer-maint at bugzilla.gnome.org
+TargetMilestone: 0.4.0
+URL: 
+Summary: Incorrect test on valloc return in gst/cothreads.c
+
+Causes some apps using multithreaded pipelines to fail with the message
+"Could not valloc stack !" on FreeBSD (and presumably any other systems
+without posix_memalign).
+
+The following one-line diff against 0.4.2 fixes the problem:
+
+--- gst/cothreads.c.orig        Fri Dec  6 19:40:17 2002
++++ gst/cothreads.c     Sun Dec  1 22:54:17 2002
+@@ -550,7 +550,7 @@
+   GST_DEBUG (GST_CAT_THREAD, "have  posix_memalign at %p of size %d",
+              (void *) *stack, STACK_SIZE);
+ #else
+-  if ((*stack = valloc (STACK_SIZE)) != 0)
++  if ((*stack = valloc (STACK_SIZE)) == 0)
+   {
+     g_warning ("Could not valloc stack !\n");
+     return FALSE;