[Gstreamer-bugs] [Bug 94429] Changed - gst_osssink_open_audio fails to open when blocked

[bugzilla-daemon at widget.gnome.org]

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

http://bugzilla.gnome.org/show_bug.cgi?id=94429

Changed by mmarquee at btinternet.com.

--- shadow/94429	Mon Oct  7 17:14:41 2002
+++ shadow/94429.tmp.21944	Mon Oct  7 18:26:58 2002
@@ -44,6 +44,18 @@
 
 ------- Additional Comments From Uraeus at linuxrising.org  2002-10-07 17:14 -------
 Mark,
 Wim is a bit unsure what this patch is meant to do. Could you please
 explain what problem it solved. It seems to ignore the return code, but
 we are not sure why you think it is a good idea to ignore errors.
+
+------- Additional Comments From mmarquee at btinternet.com  2002-10-07 18:26 -------
+This is from my testing of rhytmbox. 
+The function as is ALWAYS fails to open the device with O_NONBLOCK
+(with EBUSY as it is already open), and then simply returns failure. 
+The patch is to try to open O_NONBLOCK, and then open without it (if
+it fails),  rather than simply returning failure after the first open.
+The error is not ignored, but the rest of the code in the function
+actually gets called.
+My installation of rhythmbox (which uses osssink via monkey-media)
+simply doesn't make a sound without this change.
+