[Gstreamer-bugs] [Bug 89568] Changed - gst_pad_try_set_caps should return more than boolean

[bugzilla-daemon at widget.gnome.org]

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

http://bugzilla.gnome.org/show_bug.cgi?id=89568

Changed by rbultje at ronald.bitfreak.net.

--- shadow/89568	Wed Aug 21 18:27:52 2002
+++ shadow/89568.tmp.8377	Mon Sep  9 16:21:45 2002
@@ -10,12 +10,13 @@
 Component: gstreamer (core)
 AssignedTo: wingo at pobox.com                            
 ReportedBy: mromaine at parc.com               
 QAContact: gstreamer-maint at bugzilla.gnome.org
 TargetMilestone: 0.4.0
 URL: 
+Cc: rbultje at ronald.bitfreak.net
 Summary: gst_pad_try_set_caps should return more than boolean
 
 gstpad.c:gst_pad_try_set_caps currently only returns boolean.  The function
 however will also call gst_pad_try_set_caps_func, which returns a
 GstPadConnectReturn with more information.  If elements are in a READY
 state and a caps nego trys to happen, even if _set_caps_func returns a
@@ -36,6 +37,10 @@
 1343c1343,1345
 < 		GST_PAD_CONNECT_OK))
 ---
 > 	       GST_PAD_CONNECT_OK) &&
 > 	      (gst_pad_try_set_caps_func (peer, caps, TRUE) !=
 > 	       GST_PAD_CONNECT_DELAYED))
+
+------- Additional Comments From rbultje at ronald.bitfreak.net  2002-09-09 16:21 -------
+Capsnego in READY should work now (that was yet another bug), but this
+still applies. gst_pad_try_set_caps() should give a GstPadConnectReturn.