[Gstreamer-bugs] [Bug 119550] New - useless comparison

[bugzilla-daemon at widget.gnome.org]

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

http://bugzilla.gnome.org/show_bug.cgi?id=119550

Changed by andjoh at rydsbo.net.

--- shadow/119550	Sun Aug 10 07:53:34 2003
+++ shadow/119550.tmp.21050	Sun Aug 10 07:53:35 2003
@@ -0,0 +1,24 @@
+Bug#: 119550
+Product: GStreamer
+Version: HEAD CVS
+OS: Linux
+OS Details: 
+Status: NEW   
+Resolution: 
+Severity: normal
+Priority: Normal
+Component: gstreamer (core)
+AssignedTo: gstreamer-maint at bugzilla.gnome.org                            
+ReportedBy: andjoh at rydsbo.net               
+QAContact: gstreamer-maint at bugzilla.gnome.org
+TargetMilestone: HEAD
+URL: 
+Summary: useless comparison
+
+I don't know if this actually causes any breakage, but
+gstreamer/libs/gst/bytestream/bytestream.c, line 277 has
+
+if (GST_BUFFER_OFFSET (headbuf) != -1)
+
+Which, since GstBuffer->offset is declared unsigned, could be replaced by
+if(1). It doesn't look sensible