[Gstreamer-bugs] [Bug 128893] Changed - configure doesn't fail when the user is using a version of libfaad which is too old

[bugzilla-daemon at widget.gnome.org]

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

http://bugzilla.gnome.org/show_bug.cgi?id=128893

Changed by rbultje at ronald.bitfreak.net.

--- shadow/128893	Tue Dec  9 09:13:23 2003
+++ shadow/128893.tmp.22125	Tue Dec  9 09:16:37 2003
@@ -36,6 +36,30 @@
 incompatible pointer type
 gstfaad.c:386: error: too many arguments to function `faacDecInit'
 gstfaad.c:399: error: too many arguments to function `faacDecDecode'
 gstfaad.c:407: error: structure has no member named `samplerate'
 gstfaad.c:409: error: structure has no member named `samplerate'
 
+
+------- Additional Comments From rbultje at ronald.bitfreak.net  2003-12-09 09:16 -------
+Configure has code to check for this:
+
+dnl **** Free AAC Decoder (FAAD) ****
+translit(dnm, m, l) AM_CONDITIONAL(USE_FAAD, true)
+GST_CHECK_FEATURE(FAAD, [AAC decoder plug-in], faad, [
+  GST_CHECK_LIBHEADER(FAAD, faad, faacDecOpen, -lm, faad.h,
+FAAD_LIBS="-lfaad -lm")
+  AC_MSG_CHECKING([Checking for FAAD >= 2])   AC_TRY_COMPILE([
+#include <faad.h>
+#if !defined(FAAD2_VERSION)
+#error Not faad2
+#endif
+  ], [ return 0; ],
+     [ HAVE_FAAD="yes" && AC_MSG_RESULT(yes)],
+     [ HAVE_FAAD="no"  && AC_MSG_RESULT(no)])
+  AS_SCRUB_INCLUDE(FAAD_CFLAGS)
+  AC_SUBST(FAAD_LIBS)
+])
+
+Can you try to finetune this so it works? I only have faad2 so I'm not
+exactly sure how to catch this. It'd help if you could attach
+config.log, too...