[Gstreamer-bugs] [Bug 129164] Changed - Problems with gnome-sound-recorder and gstreamer-properties

[bugzilla-daemon at widget.gnome.org]

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

http://bugzilla.gnome.org/show_bug.cgi?id=129164

Changed by rbultje at ronald.bitfreak.net.

--- shadow/129164	Sat Dec 13 15:37:33 2003
+++ shadow/129164.tmp.785	Sun Dec 21 18:12:54 2003
@@ -5,13 +5,13 @@
 OS Details: Gentoo Linux
 Status: NEW   
 Resolution: 
 Severity: critical
 Priority: High
 Component: Gnome-Sound-Recorder
-AssignedTo: gnome-media-maint at bugzilla.gnome.org                            
+AssignedTo: rbultje at ronald.bitfreak.net                            
 ReportedBy: installation_fault_association at yahoo.fr               
 QAContact: gnome-media-qa-maint at bugzilla.gnome.org
 TargetMilestone: ---
 URL: 
 Cc: gstreamer-maint at bugzilla.gnome.org
 Summary: Problems with gnome-sound-recorder and gstreamer-properties
@@ -118,13 +118,13 @@
 
 ------- Additional Comments From installation_fault_association at yahoo.fr  2003-12-11 20:08 -------
 Created an attachment (id=22361)
 Gstreamer-properties Backtrace from bug-buddy
 
 
-------- Additional Comments From newren at math.utah.edu  2003-12-12 11:34 -------
+------- Additional Comments From bugsqueesher at yahoo.com  2003-12-12 11:34 -------
 Both stack trace are unique according to the simple-dup-finder.  I'm
 not sure whether this should be split into two bugs or kept
 together--and if they're kept together, whether this should be filed
 here or against gstreamer.  So, I'll leave it as is for now.  The
 first stack trace has debugging symbols, the second stack trace does
 too but not in the functions in the lowermost frames before the signal
@@ -134,13 +134,13 @@
 Maybe a CC to the gstreamer team would be a good idea ?
 
 ------- Additional Comments From installation_fault_association at yahoo.fr  2003-12-12 12:53 -------
 It sounds like a duplicate of this :
 http://bugzilla.gnome.org/show_bug.cgi?id=126539
 
-------- Additional Comments From newren at math.utah.edu  2003-12-12 23:04 -------
+------- Additional Comments From bugsqueesher at yahoo.com  2003-12-12 23:04 -------
 Eddahbi Karim: The steps to reproduce may sound the same as bug
 126539, but the stack traces are different meaning that you are
 triggering a different bug.  CC'ing the gstreamer people sounds like a
 good idea--that way they can help decide where this bug belongs.
 
 ------- Additional Comments From installation_fault_association at yahoo.fr  2003-12-13 08:06 -------
@@ -151,6 +151,28 @@
 Which GStreamer version? ALSA in 0.6.x is known to be broken. It
 should work in HEAD CVS (0.7.x).
 
 ------- Additional Comments From installation_fault_association at yahoo.fr  2003-12-13 15:37 -------
 I have Gstreamer 0.7.2, I'll try CVS HEAD.
 By the way I haven't gst-plugins-oss ...
+
+------- Additional Comments From rbultje at ronald.bitfreak.net  2003-12-21 18:12 -------
+OK, I finally got around to a good review of GSR tonight.
+
+Dzjeeeeeeeh!
+
+It doesn't look that bad, don't get me wrong, but it misses too much
+error correction. For each element that's created, it should check
+whether it's !NULL after creation. If not, it should give an error
+dialog and bail out (i.e. return control to user) without crashing.
+
+It doesn't do any of this.
+
+What's worse, is that saving a file to **whatever** media type appears
+to crash. The backtraces are inconsistent and the thing refuses to
+give any useful info in either gdb or valgrind (!), which leads me to
+believe we've got a nice example of well-defined memory corruption here.
+
+I'm intending to make this the general "GSR crashes on save-as or GSR
+crashes and one element is NULL" bug. Expect some dups here. I hope to
+have this fixed fairly soon. It'll take me quite some patching to get
+this correct, though.