[Gstreamer-bugs] [Bug 102353] Changed - patch for integerized vorbis decoder

[bugzilla-daemon at widget.gnome.org]

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

http://bugzilla.gnome.org/show_bug.cgi?id=102353

Changed by thomas at urgent.rug.ac.be.

--- shadow/102353	Thu Jan  2 10:23:42 2003
+++ shadow/102353.tmp.16091	Fri Jan 10 05:58:11 2003
@@ -1,12 +1,12 @@
 Bug#: 102353
 Product: GStreamer
 Version: 0.5.0
 OS: other
 OS Details: 
-Status: NEW   
+Status: NEEDINFO   
 Resolution: 
 Severity: normal
 Priority: Normal
 Component: gst-plugins
 AssignedTo: gstreamer-maint at bugzilla.gnome.org                            
 ReportedBy: pb at nexus.co.uk               
@@ -19,6 +19,29 @@
 Vorbis decoder.
 
 ------- Additional Comments From pb at nexus.co.uk  2003-01-02 10:23 -------
 Created an attachment (id=13317)
 patch for tremor plugin
 
+
+------- Additional Comments From thomas at urgent.rug.ac.be  2003-01-10 05:58 -------
+Hi,
+
+this looks great to have !
+I'd love it if we could integrate is.
+
+I looked over the patch, and have a few comments:
+
+a) use of config.h.in is deprecated, so you shouldn't have to patch
+that.  I will look at removing that definitively.
+b) your code looks like a copy/paste of vorbisfile, so I assume that
+the tremor interface is very similar to it.
+However, all of the symbols need renaming so they don't clash with
+vorbisfile.  Do you think you could do that and resubmit the patch so
+that it doesn't clash ?
+
+I could do it myself, but the patch will be integrated a lot quicker
+if it doesn't clash :)
+
+Thanks for doing this !
+
+Thomas