[Gstreamer-bugs] [Bug 102719] Changed - [PATCH] gst_mpeg_parse_parse_packhead reads outside the buffer

[bugzilla-daemon at widget.gnome.org]

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

http://bugzilla.gnome.org/show_bug.cgi?id=102719

Changed by thomas at urgent.rug.ac.be.

--- shadow/102719	Wed Jan  8 16:55:16 2003
+++ shadow/102719.tmp.11747	Fri Jan 17 10:31:19 2003
@@ -5,19 +5,38 @@
 OS Details: 
 Status: NEW   
 Resolution: 
 Severity: normal
 Priority: Normal
 Component: gst-plugins
-AssignedTo: gstreamer-maint at bugzilla.gnome.org                            
+AssignedTo: wim.taymans at chello.be                            
 ReportedBy: vishnu at pobox.com               
 QAContact: gstreamer-maint at bugzilla.gnome.org
 TargetMilestone: 0.4.0
 URL: 
 Summary: [PATCH] gst_mpeg_parse_parse_packhead reads outside the buffer
 
 valgrind is amazing.  three cheers for valgrind.
 
 ------- Additional Comments From vishnu at pobox.com  2003-01-06 23:53 -------
 Created an attachment (id=13394)
 re-code logic to avoid reading outside the buffer
 
+
+------- Additional Comments From thomas at urgent.rug.ac.be  2003-01-17 10:31 -------
+Joshua,
+
+Thanks for that patch.
+
+a few remarks:
+
+- the GUINT-macro's are very useful for endianness, so not using them
+will probably cause us a lot of problems in that area.  So I think we
+should keep using them.
+- can you say how it can happen that the 4th byte is out of range ? I
+suspect valgrind put you on the track, but did you also find out why
+this could be a problem ?
+- isn't there a possibility for a workaround to check this, and then
+use an endian-correct way to get at the data ? An alternative might be
+to allocate one byte more by default for the buffer or something.
+- please don't use // :)
+