[Gstreamer-bugs] [Bug 115886] Changed - gst_caps_has_(fixed_)property() prints an assertion before returning false

[bugzilla-daemon at widget.gnome.org]

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

http://bugzilla.gnome.org/show_bug.cgi?id=115886

Changed by rbultje at ronald.bitfreak.net.

--- shadow/115886	Mon Jun 30 19:12:36 2003
+++ shadow/115886.tmp.2403	Tue Jul  1 04:18:31 2003
@@ -86,6 +86,15 @@
 
 I mostly got a consensus on IRC that gst_caps_*() code should properly
 handle caps==NULL and caps->properties==NULL, but gst_props_*()
 functions can expect (and assert) that they are called with props !=
 NULL.  This is because the props code is almost exclusively used by
 caps, whereas caps is used by plugins and apps.
+
+------- Additional Comments From rbultje at ronald.bitfreak.net  2003-07-01 04:18 -------
+I just had the thought that we might want to make it obligatory to
+make every caps have a GstProps, even though it might be empty
+(gst_props_new_empty ()). This would need some plugin fixage, but it'd
+fix the issue, too.
+
+If we want to stick to allowing NULL as valid caps->props, then here's
+a patch that does what dave asked for.