[Gstreamer-bugs] [Bug 116185] Changed - flacdec doesn't work when src pad is not connected

[bugzilla-daemon at widget.gnome.org]

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

http://bugzilla.gnome.org/show_bug.cgi?id=116185

Changed by in7y118 at public.uni-hamburg.de.

--- shadow/116185	Mon Jun 30 03:27:13 2003
+++ shadow/116185.tmp.15793	Wed Jul  2 11:47:55 2003
@@ -82,6 +82,29 @@
 100+ of plugins if we want to do this completely. That's insane,
 nothing less. If we intend to support these kind of features, then
 make a proper solution for this in the core so that we don't have to
 bloat each single plugin with the same code.
 
 That's mho. ;).
+
+------- Additional Comments From in7y118 at public.uni-hamburg.de  2003-07-02 11:47 -------
+No, if we want to support it cleanly, we will implement the _USABLE 
+check in gst_pad_push.
+
+It is a thing of defining if pads may be left unconnected and which 
+ones. I personally think it is ok to have unconnected source pads 
+(the example being demuxers when you only want audio - like Marlin 
+opening an AVI) and unconnected sink pads (example being an adder 
+where some pads are lying around) - though someone needs to define 
+what gst_pad_pull does in that case.
+
+
+However it is _NOT_ ok (and I have a very strong opinion here) to 
+rely on a decoder mutating to a metadata-getter when you don't 
+connect the source pad(s). Plugins do _one_ clearly defined job and 
+do that one only.
+If you want a FLAC metadata extraction plugin, write one. That should 
+be reasonably easy and would offer the great benefit of having the 
+possibility of implementing a subclass that does metadata editing.
+
+btw: both mad and vorbisfile decode the data but discard it when they 
+are unconnected if I'm not mistaken.