[Gstreamer-bugs] [Bug 110129] Changed - Winamp windows m3u playlist compatibility

[bugzilla-daemon at widget.gnome.org]

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

http://bugzilla.gnome.org/show_bug.cgi?id=110129

Changed by hadess at hadess.net.

--- shadow/110129	Tue Jun 24 22:51:45 2003
+++ shadow/110129.tmp.14400	Wed Jun 25 08:26:58 2003
@@ -68,6 +68,27 @@
 
 
 ------- Additional Comments From oachler at ucsd.edu  2003-06-24 22:51 -------
 Created an attachment (id=17748)
 unified diff of previous attachment
 
+
+------- Additional Comments From hadess at hadess.net  2003-06-25 08:26 -------
+The changes to gtk_playlist_add_mrl_with_data are broken. The
+gnome_vfs_get_mime_type call in gtk_playlist_add_mrl should already
+figure out that it's an m3u file.
+
+The changes to gtk_playlist_add_m3u are slightly broken too.
+Instead of:
++	char *split_char = "  ";
++                split_char = "\n\0"; /* This is broken, the string
+will end up with 2 null-terminators */
+You should have something like:
+char *split_char;
+split_char = "\n";
+
+To create your patches more easily, you could:
+1) checkout totem from the GNOME CVS.
+2) Once you have checked it out, modify src/gtk-playlist.c
+3) Send us the output of "cvs diff -u" (makes diffing a lot easier :)
+
+Thanks for working on that